Re: [Qemu-devel] [PATCH 1/2] net: make iov_to_buf take right size argument in nc_sendv_compat()

[Jason Wang <jasowang@redhat.com>]

On 10/20/2015 09:51 AM, Yang Hongyang wrote:
> We want "buf, sizeof(buf)" here.  sizeof(buffer) is the size of a
> pointer, which is wrong.
> Thanks to Paolo for pointing it out.
>
> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  net/net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/net.c b/net/net.c
> index 39af893..0c4a012 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -700,7 +700,7 @@ static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov,
>          offset = iov[0].iov_len;
>      } else {
>          buffer = buf;
> -        offset = iov_to_buf(iov, iovcnt, 0, buffer, sizeof(buffer));
> +        offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf));
>      }
>  
>      if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) {

Both two patches were applied in:

https://github.com/jasowang/qemu/commits/net

Thanks