From mboxrd@z Thu Jan 1 00:00:00 1970 From: puck.chen@hisilicon.com (chenfeng) Date: Tue, 20 Oct 2015 18:17:13 +0800 Subject: [PATCH V2 3/3] Add dts node for smmu on hi6220 SoC In-Reply-To: <39316856.jTQkIxu0yn@wuerfel> References: <1445330724-129401-1-git-send-email-puck.chen@hisilicon.com> <1445330724-129401-3-git-send-email-puck.chen@hisilicon.com> <39316856.jTQkIxu0yn@wuerfel> Message-ID: <562614A9.8050501@hisilicon.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Thanks for review. On 2015/10/20 17:00, Arnd Bergmann wrote: > On Tuesday 20 October 2015 16:45:24 Chen Feng wrote: >> + >> + smmu at f4210000 { > > I think the canonical name for an IOMMU device is 'iommu', not 'smmu'. Accept. > >> + compatible = "hisilicon,hi6220-smmu"; >> + reg = <0x0 0xf4210000 0x0 0x1000>; >> + interrupts = ; >> + clocks = <&sys_ctrl HI6220_MMU_CLK>, >> + <&media_ctrl HI6220_MED_MMU>, >> + <&sys_ctrl HI6220_MEDIA_PLL_SRC>; >> + clock-names = "smmu_clk", >> + "media_sc_clk", >> + "smmu_peri_clk"; > > > Better avoid underscores in strings, and drop the "_clk" postfix in > the clock names. > > I did not receive patch 1/3 this time, but I see in version 1, that > you forgot to document the strings: > Accept, I will change this. >> +- clock-names: The name to enable clock with clock framework. > > This needs to list the names of the clock inputs to the smmu. > > Arnd > _______________________________________________ > linuxarm mailing list > linuxarm at huawei.com > http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: chenfeng Subject: Re: [PATCH V2 3/3] Add dts node for smmu on hi6220 SoC Date: Tue, 20 Oct 2015 18:17:13 +0800 Message-ID: <562614A9.8050501@hisilicon.com> References: <1445330724-129401-1-git-send-email-puck.chen@hisilicon.com> <1445330724-129401-3-git-send-email-puck.chen@hisilicon.com> <39316856.jTQkIxu0yn@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <39316856.jTQkIxu0yn@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org, z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, qijiwen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, weidong2-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, suzhuangluan-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, puck.chen-Dw/NWeUnuQfQT0dZR+AlfA@public.gmane.org, yudongbin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, peter.panshilin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, saberlily.xia-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org List-Id: devicetree@vger.kernel.org Thanks for review. On 2015/10/20 17:00, Arnd Bergmann wrote: > On Tuesday 20 October 2015 16:45:24 Chen Feng wrote: >> + >> + smmu@f4210000 { > > I think the canonical name for an IOMMU device is 'iommu', not 'smmu'. Accept. > >> + compatible = "hisilicon,hi6220-smmu"; >> + reg = <0x0 0xf4210000 0x0 0x1000>; >> + interrupts = ; >> + clocks = <&sys_ctrl HI6220_MMU_CLK>, >> + <&media_ctrl HI6220_MED_MMU>, >> + <&sys_ctrl HI6220_MEDIA_PLL_SRC>; >> + clock-names = "smmu_clk", >> + "media_sc_clk", >> + "smmu_peri_clk"; > > > Better avoid underscores in strings, and drop the "_clk" postfix in > the clock names. > > I did not receive patch 1/3 this time, but I see in version 1, that > you forgot to document the strings: > Accept, I will change this. >> +- clock-names: The name to enable clock with clock framework. > > This needs to list the names of the clock inputs to the smmu. > > Arnd > _______________________________________________ > linuxarm mailing list > linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org > http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbbJTKnK (ORCPT ); Tue, 20 Oct 2015 06:43:10 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:53706 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbbJTKnH (ORCPT ); Tue, 20 Oct 2015 06:43:07 -0400 Subject: Re: [PATCH V2 3/3] Add dts node for smmu on hi6220 SoC To: Arnd Bergmann References: <1445330724-129401-1-git-send-email-puck.chen@hisilicon.com> <1445330724-129401-3-git-send-email-puck.chen@hisilicon.com> <39316856.jTQkIxu0yn@wuerfel> CC: , , , , , , , , , , , , , , , , , , From: chenfeng Message-ID: <562614A9.8050501@hisilicon.com> Date: Tue, 20 Oct 2015 18:17:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <39316856.jTQkIxu0yn@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.192.172] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.56261AAD.009A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b799de42a3845aee250646584e003d25 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for review. On 2015/10/20 17:00, Arnd Bergmann wrote: > On Tuesday 20 October 2015 16:45:24 Chen Feng wrote: >> + >> + smmu@f4210000 { > > I think the canonical name for an IOMMU device is 'iommu', not 'smmu'. Accept. > >> + compatible = "hisilicon,hi6220-smmu"; >> + reg = <0x0 0xf4210000 0x0 0x1000>; >> + interrupts = ; >> + clocks = <&sys_ctrl HI6220_MMU_CLK>, >> + <&media_ctrl HI6220_MED_MMU>, >> + <&sys_ctrl HI6220_MEDIA_PLL_SRC>; >> + clock-names = "smmu_clk", >> + "media_sc_clk", >> + "smmu_peri_clk"; > > > Better avoid underscores in strings, and drop the "_clk" postfix in > the clock names. > > I did not receive patch 1/3 this time, but I see in version 1, that > you forgot to document the strings: > Accept, I will change this. >> +- clock-names: The name to enable clock with clock framework. > > This needs to list the names of the clock inputs to the smmu. > > Arnd > _______________________________________________ > linuxarm mailing list > linuxarm@huawei.com > http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm > > . >