From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: Dom0 kernel for Xen4.6 on R-Car H2 (LAGER)
Date: Tue, 20 Oct 2015 11:47:26 +0100
Message-ID: <56261BBE.9090708@citrix.com>
References: <5a0aab3289b446c1877348268f2afc39@DEBEMAIL001.kostal.int>
	<1444919269.1607.95.camel@citrix.com>
	<0234f7a69dc647fa80b6d16a8f5a7fc8@DEBEMAIL001.kostal.int>
	<5624E5A0.4030906@citrix.com>
	<5599c29cfd794dee98c5beebb18cee28@DEBEMAIL001.kostal.int>
	<562611D1.5050501@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <562611D1.5050501@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Ferger, Max" <M.Ferger@KOSTAL.COM>, Ian Campbell <ian.campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>, Iurii Konovalenko <iurii.konovalenko@globallogic.com>
List-Id: xen-devel@lists.xenproject.org

On 20/10/2015 11:05, Julien Grall wrote:
> Thank you for the log. The offending node is /pci@ee090000/usb@0,1 which
> is (r8a7790.dtsi):
>
> 1407                 usb@0,1 {
> 1408                         reg = <0x800 0 0 0 0>;
> 1409                         device_type = "pci";
> 1410                         phys = <&usb0 0>;
> 1411                         phy-names = "usb";
> 1412                 };
> 1413
>
> We assume that every node containing device_type = "pci" is a PCI bus.
> So Xen is looking for a property "ranges" which is not present.
>
> Although, here it's describing a PCI device. I wasn't able to find a
> spec telling that device_type = "pci"; should only be used by the PCI
> bus. Ian, do you remember why you implement with this assumption?
>
> For now, I would advice you to drop this node, the next one (usb@0,2)
> and doing the same in "pci@ee0d0000". We can figure out later how to fix
> it when you get a DOM0 booting.

Better solution, rather than dropping the nodes can you add "ranges;" in 
each of them. Smth like

usb@0,1 {
   reg = <0x800 0 0 0 0>;
   device_type = "pci";
   phys = <&usb0 0>;
   phy-names = "usb";
   ranges;
}

"ranges;" is used to tell the PCI device is using the same address space 
of the PCI bus. There is DT bindings describing how look like the 
subnode and they mandate the property "ranges" (see [1], [2]). Although 
renesas doesn't seem to require it. Might be worth to investigate it.

Regards,

[1] 
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/pci/mvebu-pci.txt
[2] 
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt

-- 
Julien Grall