From: Tomas Henzl <thenzl@redhat.com>
To: Chad Dupuis <chad.dupuis@qlogic.com>,
James.Bottomley@HansenPartnership.com
Cc: giridhar.malavali@qlogic.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 6/7] bnx2fc: Add HZ to task management timeout.
Date: Tue, 20 Oct 2015 13:47:10 +0200 [thread overview]
Message-ID: <562629BE.4020904@redhat.com> (raw)
In-Reply-To: <1445283641-7358-7-git-send-email-chad.dupuis@qlogic.com>
On 19.10.2015 21:40, Chad Dupuis wrote:
> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
> Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h
> index d46267d..d05866d 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc.h
> +++ b/drivers/scsi/bnx2fc/bnx2fc.h
> @@ -129,7 +129,7 @@
> #define BNX2FC_MAX_FCP_TGT 256
> #define BNX2FC_MAX_CMD_LEN 16
>
> -#define BNX2FC_TM_TIMEOUT 60 /* secs */
> +#define BNX2FC_TM_TIMEOUT (60 * HZ) /* seconds */
Hi Chad,
when you add HZ here it should be removed from bnx2fc_initiate_tmf :
rc = wait_for_completion_timeout(&io_req->tm_done,
BNX2FC_TM_TIMEOUT * HZ);
Cheers,
Tomas
> #define BNX2FC_IO_TIMEOUT 20000UL /* msecs */
>
> #define BNX2FC_WAIT_CNT 1200
next prev parent reply other threads:[~2015-10-20 11:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 19:40 [PATCH 0/7] bnx2fc: Update to version 2.9.6 Chad Dupuis
2015-10-19 19:40 ` [PATCH 1/7] bnx2fc: Update copyright for 2015 Chad Dupuis
2015-10-21 10:19 ` Hannes Reinecke
2015-10-22 14:50 ` Tomas Henzl
2015-10-19 19:40 ` [PATCH 2/7] bnx2fc: Remove 'NetXtreme II' from source files Chad Dupuis
2015-10-21 10:22 ` Hannes Reinecke
2015-10-22 14:50 ` Tomas Henzl
2015-10-19 19:40 ` [PATCH 3/7] bnx2fc: Set ELS transfer length correctly for middle path commands Chad Dupuis
2015-10-21 10:23 ` Hannes Reinecke
2015-10-22 14:53 ` Tomas Henzl
2015-10-19 19:40 ` [PATCH 4/7] bnx2fc: Fix FCP RSP residual parsing Chad Dupuis
2015-10-21 10:23 ` Hannes Reinecke
2015-10-22 14:54 ` Tomas Henzl
2015-10-19 19:40 ` [PATCH 5/7] bnx2fc: Remove explicit logouts Chad Dupuis
2015-10-21 10:30 ` Hannes Reinecke
2015-10-22 14:54 ` Tomas Henzl
2015-10-19 19:40 ` [PATCH 6/7] bnx2fc: Add HZ to task management timeout Chad Dupuis
2015-10-20 11:47 ` Tomas Henzl [this message]
2015-10-20 14:17 ` Chad Dupuis
2015-10-21 10:30 ` Hannes Reinecke
2015-10-19 19:40 ` [PATCH 7/7] bnx2fc: Update version number to 2.9.6 Chad Dupuis
2015-10-21 10:31 ` Hannes Reinecke
2015-10-22 14:55 ` Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562629BE.4020904@redhat.com \
--to=thenzl@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=chad.dupuis@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.