Re: [Qemu-devel] [PATCH] qxl: lock current_async update in qxl_soft_reset

[Paolo Bonzini <pbonzini@redhat.com>]

On 20/10/2015 09:58, Gerd Hoffmann wrote:
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/display/qxl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index 9c961da..20dc72e 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -1156,7 +1156,9 @@ static void qxl_soft_reset(PCIQXLDevice *d)
>      trace_qxl_soft_reset(d->id);
>      qxl_check_state(d);
>      qxl_clear_guest_bug(d);
> +    qemu_mutex_lock(&d->async_lock);
>      d->current_async = QXL_UNDEFINED_IO;
> +    qemu_mutex_unlock(&d->async_lock);
>  
>      if (d->id == 0) {
>          qxl_enter_vga_mode(d);
> 

Thanks, this should fix a defect report from Coverity.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>