From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 02/10] x86/mm: override stored file names
 for multiply built sources
Date: Tue, 20 Oct 2015 13:44:28 +0100
Message-ID: <5626372C.6040308@citrix.com>
References: <5626340902000078000ACB1F@prv-mh.provo.novell.com>
	<562635FC02000078000ACB35@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=728a4bfaa=Andrew.Cooper3@citrix.com>)
	id 1ZoWHN-0002of-5N
	for xen-devel@lists.xenproject.org; Tue, 20 Oct 2015 12:44:37 +0000
In-Reply-To: <562635FC02000078000ACB35@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 20/10/15 11:39, Jan Beulich wrote:
> To make it possible to tell apart the static symbols therein, use their
> object file names instead of their source ones.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

In principle, a very good idea.

Is it perhaps worth having the build runes pass in a -D value instead,
so as to avoid the .file reference getting stale?

>
> --- a/xen/arch/x86/mm/guest_walk.c
> +++ b/xen/arch/x86/mm/guest_walk.c
> @@ -29,6 +29,8 @@
>  #include <asm/page.h>
>  #include <asm/guest_pt.h>
>  
> +/* Allow uniquely identifying static symbols in the 3 generated objects. */
> +asm(".file \"guest_walk_" __stringify(GUEST_PAGING_LEVELS) ".o\"");

You should probably have a semicolon or newline at the end, to avoid
interacting with whatever the next directive the compiler chooses to
emit is.

~Andrew