From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 05/10] x86/mm: build map_domain_gfn() just
	once
Date: Tue, 20 Oct 2015 13:54:24 +0100
Message-ID: <56263980.5040806@citrix.com>
References: <5626340902000078000ACB1F@prv-mh.provo.novell.com>
	<5626369102000078000ACB63@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=728a4bfaa=Andrew.Cooper3@citrix.com>)
	id 1ZoWQw-0004Du-00
	for xen-devel@lists.xenproject.org; Tue, 20 Oct 2015 12:54:30 +0000
In-Reply-To: <5626369102000078000ACB63@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 20/10/15 11:41, Jan Beulich wrote:
> It doesn't depend on GUEST_PAGING_LEVELS.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> TBD: To ensure no dependency on GUEST_PAGING_LEVELS, would it perhaps
>      be better to move the function to a file compiled just once?

+1  it probably fits best in p2m.c, although none of the surrounding
files is a particularly good fit.

If there are other generic helpers, it might be worth making a common.c

~Andrew