From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF36FC00A89 for ; Mon, 2 Nov 2020 13:41:48 +0000 (UTC) Received: from lists.lttng.org (lists.lttng.org [167.114.26.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF5EE206E5 for ; Mon, 2 Nov 2020 13:41:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.lttng.org header.i=@lists.lttng.org header.b="kCZlJ16C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF5EE206E5 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.lttng.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lttng-dev-bounces@lists.lttng.org Received: from lists-lttng01.efficios.com (localhost [IPv6:::1]) by lists.lttng.org (Postfix) with ESMTP id 4CPvGK41RLz1Bc1; Mon, 2 Nov 2020 08:41:45 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.lttng.org; s=default; t=1604324506; bh=Q+HRlHn9jacsjOvWxHCmdXK2L2O/ApO95tygHSJ0efg=; h=Date:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=kCZlJ16Cs04fG/82enrF18TSLXeHF4BZBUp2fDbYVzmDLCbX53pA6+O/amJAP0taG mluUYA424wxXJYrcflmkgevhvci8/SvAotgJVJfOsmGrraCmQrssquKncWCDLWZJQQ eC1V1smTFpjVEJipE5L1CGeO7NoRfSaX9arP3fxAJHiJLyv5K7Qm48Y5LVly+t5DYG RG3zb95GGjFA4AbTlGF6aHgRKKpGhbO3RMdfMGwnsRMm3PGp3J26HkNgKG25ayVags 67FJ9dEq3lXvHhhVDQmJEr+5C1YbmHrXM1sMoF6Eebx0I2R0iMnafX62fROJKPggh7 qllpTnXQYsQEQ== Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by lists.lttng.org (Postfix) with ESMTPS id 4CPvGG6lg9z1BYW for ; Mon, 2 Nov 2020 08:41:41 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 8F48B2A98A2; Mon, 2 Nov 2020 08:41:41 -0500 (EST) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XGqQTB6BC3ZM; Mon, 2 Nov 2020 08:41:41 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 28E652A98A1; Mon, 2 Nov 2020 08:41:41 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 28E652A98A1 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OhRzxlVdHtAR; Mon, 2 Nov 2020 08:41:41 -0500 (EST) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id 1D7522A96DC; Mon, 2 Nov 2020 08:41:41 -0500 (EST) Date: Mon, 2 Nov 2020 08:41:41 -0500 (EST) To: Michael Jeanson Cc: lttng-dev Message-ID: <562662876.6926.1604324501008.JavaMail.zimbra@efficios.com> In-Reply-To: <20201030193956.292208-1-mjeanson@efficios.com> References: <20201030193956.292208-1-mjeanson@efficios.com> MIME-Version: 1.0 X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_3975 (ZimbraWebClient - FF82 (Linux)/8.8.15_GA_3975) Thread-Topic: add -lurcu-common to pkg-config libs for each flavor Thread-Index: wfOJjohMdTqUaNdgCZQpv9DqP3PSWA== Subject: Re: [lttng-dev] [PATCH urcu] fix: add -lurcu-common to pkg-config libs for each flavor X-BeenThere: lttng-dev@lists.lttng.org X-Mailman-Version: 2.1.31 Precedence: list List-Id: LTTng development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mathieu Desnoyers via lttng-dev Reply-To: Mathieu Desnoyers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: lttng-dev-bounces@lists.lttng.org Sender: "lttng-dev" Merged into liburcu master, 0.11, 0.12, thanks! Mathieu ----- On Oct 30, 2020, at 3:39 PM, Michael Jeanson mjeanson@efficios.com wrote: > The urcu-common library contains common code like the write-free queue > and compat code, each urcu flavor library is dynamicly linked with it. > > Most but not all toolchains will automatically link an executable with a > transitive depency of an explicitly linked library if said binary uses a > symbol from the transitive dependency. > > Since this behavior is not present in all toolchains, add > '-lurcu-common' to the 'Libs' field of each flavors pkg-config file so > that executables using symbols from urcu-common can be reliably linked > using pkg-config. > > Signed-off-by: Michael Jeanson > --- > src/liburcu-bp.pc.in | 2 +- > src/liburcu-cds.pc.in | 2 +- > src/liburcu-mb.pc.in | 2 +- > src/liburcu-qsbr.pc.in | 2 +- > src/liburcu-signal.pc.in | 2 +- > src/liburcu.pc.in | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/liburcu-bp.pc.in b/src/liburcu-bp.pc.in > index c5f2355..7cba58a 100644 > --- a/src/liburcu-bp.pc.in > +++ b/src/liburcu-bp.pc.in > @@ -7,5 +7,5 @@ Name: Userspace RCU BulletProof > Description: A userspace RCU (read-copy-update) library, bulletproof version > Version: @PACKAGE_VERSION@ > Requires: > -Libs: -L${libdir} -lurcu-bp > +Libs: -L${libdir} -lurcu-common -lurcu-bp > Cflags: -I${includedir} > diff --git a/src/liburcu-cds.pc.in b/src/liburcu-cds.pc.in > index e3d13af..1cb19b6 100644 > --- a/src/liburcu-cds.pc.in > +++ b/src/liburcu-cds.pc.in > @@ -7,5 +7,5 @@ Name: Userspace RCU Concurrent Data Structures > Description: Data structures leveraging RCU and atomic operations to provide > efficient concurrency-aware storage > Version: @PACKAGE_VERSION@ > Requires: > -Libs: -L${libdir} -lurcu-cds > +Libs: -L${libdir} -lurcu-common -lurcu-cds > Cflags: -I${includedir} > diff --git a/src/liburcu-mb.pc.in b/src/liburcu-mb.pc.in > index cd669ef..1684701 100644 > --- a/src/liburcu-mb.pc.in > +++ b/src/liburcu-mb.pc.in > @@ -7,5 +7,5 @@ Name: Userspace RCU Memory barriers > Description: A userspace RCU (read-copy-update) library, memory barriers version > Version: @PACKAGE_VERSION@ > Requires: > -Libs: -L${libdir} -lurcu-mb > +Libs: -L${libdir} -lurcu-common -lurcu-mb > Cflags: -I${includedir} > diff --git a/src/liburcu-qsbr.pc.in b/src/liburcu-qsbr.pc.in > index 0732602..d123a10 100644 > --- a/src/liburcu-qsbr.pc.in > +++ b/src/liburcu-qsbr.pc.in > @@ -7,5 +7,5 @@ Name: Userspace RCU QSBR > Description: A userspace RCU (read-copy-update) library, quiescent state version > Version: @PACKAGE_VERSION@ > Requires: > -Libs: -L${libdir} -lurcu-qsbr > +Libs: -L${libdir} -lurcu-common -lurcu-qsbr > Cflags: -I${includedir} > diff --git a/src/liburcu-signal.pc.in b/src/liburcu-signal.pc.in > index f9bc3a3..844c449 100644 > --- a/src/liburcu-signal.pc.in > +++ b/src/liburcu-signal.pc.in > @@ -7,5 +7,5 @@ Name: Userspace RCU signal > Description: A userspace RCU (read-copy-update) library, signal version > Version: @PACKAGE_VERSION@ > Requires: > -Libs: -L${libdir} -lurcu-signal > +Libs: -L${libdir} -lurcu-common -lurcu-signal > Cflags: -I${includedir} > diff --git a/src/liburcu.pc.in b/src/liburcu.pc.in > index 22bf2c8..b9f812b 100644 > --- a/src/liburcu.pc.in > +++ b/src/liburcu.pc.in > @@ -7,5 +7,5 @@ Name: Userspace RCU > Description: A userspace RCU (read-copy-update) library, standard version > Version: @PACKAGE_VERSION@ > Requires: > -Libs: -L${libdir} -lurcu > +Libs: -L${libdir} -lurcu-common -lurcu > Cflags: -I${includedir} > -- > 2.28.0 -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev