From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:47691 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbbJTT5m (ORCPT ); Tue, 20 Oct 2015 15:57:42 -0400 Message-ID: <56269C34.3000306@xs4all.nl> Date: Tue, 20 Oct 2015 21:55:32 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Benoit Parrot CC: linux-media@vger.kernel.org Subject: Re: [Patch v2 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture driver References: <1442865848-19280-1-git-send-email-bparrot@ti.com> <1442865848-19280-2-git-send-email-bparrot@ti.com> <562112B7.7090103@xs4all.nl> In-Reply-To: <562112B7.7090103@xs4all.nl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 10/16/2015 05:07 PM, Hans Verkuil wrote: > On 09/21/2015 10:04 PM, Benoit Parrot wrote: >> The Camera Adaptation Layer (CAL) is a block which consists of a dual >> port CSI2/MIPI camera capture engine. >> Port #0 can handle CSI2 camera connected to up to 4 data lanes. >> Port #1 can handle CSI2 camera connected to up to 2 data lanes. >> The driver implements the required API/ioctls to be V4L2 compliant. >> Driver supports the following: >> - V4L2 API using DMABUF/MMAP buffer access based on videobuf2 api >> - Asynchronous sensor sub device registration >> - DT support >> >> Signed-off-by: Benoit Parrot >> --- >> drivers/media/platform/Kconfig | 12 + >> drivers/media/platform/Makefile | 2 + >> drivers/media/platform/ti-vpe/Makefile | 4 + >> drivers/media/platform/ti-vpe/cal.c | 2161 ++++++++++++++++++++++++++++++ >> drivers/media/platform/ti-vpe/cal_regs.h | 779 +++++++++++ >> 5 files changed, 2958 insertions(+) >> create mode 100644 drivers/media/platform/ti-vpe/cal.c >> create mode 100644 drivers/media/platform/ti-vpe/cal_regs.h >> >> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig >> index dc75694ac12d..c7f5704c56a2 100644 >> --- a/drivers/media/platform/Kconfig >> +++ b/drivers/media/platform/Kconfig >> @@ -120,6 +120,18 @@ source "drivers/media/platform/s5p-tv/Kconfig" >> source "drivers/media/platform/am437x/Kconfig" >> source "drivers/media/platform/xilinx/Kconfig" >> >> +config VIDEO_TI_CAL >> + tristate "TI CAL (Camera Adaptation Layer) driver" >> + depends on VIDEO_DEV && VIDEO_V4L2 && SOC_DRA7XX >> + depends on VIDEO_V4L2_SUBDEV_API >> + depends on VIDEOBUF2_DMA_CONTIG > > This should be: > > depends on VIDEO_DEV && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > depends on SOC_DRA7XX || COMPILE_TEST > select VIDEOBUF2_DMA_CONTIG > >> + default n >> + ---help--- >> + Support for the TI CAL (Camera Adaptation Layer) block >> + found on DRA72X SoC. >> + In TI Technical Reference Manual this module is referred as >> + Camera Interface Subsystem (CAMSS). >> + >> endif # V4L_PLATFORM_DRIVERS >> >> menuconfig V4L_MEM2MEM_DRIVERS > > By compiling with COMPILE_TEST I found a number of compile warnings and it also no > longer compiled due to vb2 changes. Both are fixed in the patch below. > > SoB for the patch: Signed-off-by: Hans Verkuil > > That said, I'll postpone merging this until the remainder of the vb2 split patches > have been merged. When that's done this driver will have to be changed some more. OK, the vb2 split patches were just merged. Can you rebase and repost? Thanks, Hans