Re: [PATCH 3/3] ARM: bcm2835: dt: Add Raspberry Pi Model A+

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 10/11/2015 01:37 PM, Lubomir Rintel wrote:
> Essentially the same as B+.

(It'd be good practice to CC RPi patches to the ARM kernel mailing list too)

> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts

> +	leds {
> +		act {
> +			gpios = <&gpio 47 0>;
> +		};
> +
> +		pwr {
> +			label = "PWR";
> +			gpios = <&gpio 35 0>;
> +			default-state = "keep";
> +			linux,default-trigger = "default-on";
> +		};
> +	};

Since the A+ and B+ are so similar, I wonder if it makes sense to
sometime create a shared "plus" .dtsi file for the shared parts?

Same for the I2S below.

Perhaps the DTs are so simple that it's a waste of complexity to do that
though.

Out of curiosity, are you planning on creating DT files for all the
possible options:

		"bcm2835-rpi-a.dtb",
		"bcm2835-rpi-a-plus.dtb",
		"bcm2835-rpi-b.dtb",
		"bcm2835-rpi-b-i2c0.dtb",
		"bcm2835-rpi-b-plus.dtb",
		"bcm2835-rpi-b-rev2.dtb",
		"bcm2835-rpi-cm.dtb",
		"bcm2836-rpi-2-b.dtb",

(list taken from U-Boot's board/raspberrypi/rpi/rpi.c)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html