From: Pingbo Wen <pingbo.wen@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>, y2038@lists.linaro.org
Cc: dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [Y2038] [PATCH] hp_sdc: fixed y2038 problem
Date: Wed, 21 Oct 2015 16:52:16 +0800 [thread overview]
Message-ID: <56275240.5040907@linaro.org> (raw)
In-Reply-To: <5041745.xAgMz1TQSE@wuerfel>
On Monday, October 19, 2015 05:01 PM, Arnd Bergmann wrote:
> On Sunday 18 October 2015 17:44:19 WEN Pingbo wrote:
>> Two replacements happened in this patch:
>> 1. using timespec64 to prevent time overflow in 2038
>> 2. using ktime_get_ts64 to avoid wall time issues(leap second, etc)
>>
>> Signed-off-by: WEN Pingbo <pingbo.wen@linaro.org>
>>
>
> The patch looks correct, but I think this could be written a little
> simpler and clearer using ktime_get() or ktime_getns().
>
That make sense, Maybe it can save a sec shift operation. I will check it later.
Pingbo
next prev parent reply other threads:[~2015-10-21 8:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 9:44 [PATCH] hp_sdc: fixed y2038 problem WEN Pingbo
2015-10-18 9:44 ` WEN Pingbo
2015-10-19 9:01 ` [Y2038] " Arnd Bergmann
2015-10-21 8:52 ` Pingbo Wen [this message]
2015-10-23 8:53 ` [PATCH V2] " WEN Pingbo
2015-10-23 9:25 ` [Y2038] " Arnd Bergmann
2015-10-23 9:31 ` Pingbo Wen
2015-10-23 9:31 ` [Y2038] " Pingbo Wen
2015-10-23 11:29 ` [PATCH V3] hp_sdc: convert struct timeval to ktime_t WEN Pingbo
2015-10-23 11:45 ` Arnd Bergmann
2015-10-23 11:45 ` Arnd Bergmann
2015-10-23 12:19 ` Pingbo Wen
2015-10-23 12:19 ` Pingbo Wen
2015-10-23 12:34 ` Arnd Bergmann
2015-10-24 4:07 ` [PATCH V4] " WEN Pingbo
2015-10-24 4:07 ` WEN Pingbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56275240.5040907@linaro.org \
--to=pingbo.wen@linaro.org \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.