From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE)
Date: Wed, 21 Oct 2015 10:20:04 +0100 [thread overview]
Message-ID: <562758C4.1010903@imgtec.com> (raw)
In-Reply-To: <87pp09jnty.fsf@dell.be.48ers.dk>
Hello Peter,
On 10/20/2015 09:18 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>
> A more detailed commit message would be good. Is this just for
> consistency or does it fix anything? (E.G. does the build system execute
> anything from HOST_DIR)?
No, it's just for consistency.
Regards,
Vincent.
>
>> ---
> > package/dhcpdump/dhcpdump.mk | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
>
> > diff --git a/package/dhcpdump/dhcpdump.mk b/package/dhcpdump/dhcpdump.mk
> > index 6b677a6..3584f4f 100644
> > --- a/package/dhcpdump/dhcpdump.mk
> > +++ b/package/dhcpdump/dhcpdump.mk
> > @@ -16,8 +16,8 @@ DHCPDUMP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`
> > endif
>
> > define DHCPDUMP_BUILD_CMDS
> > - $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) -D_GNU_SOURCE" \
> > - LIBS="$(DHCPDUMP_LIBS)"
> > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) \
> > + -D_GNU_SOURCE" LIBS="$(DHCPDUMP_LIBS)"
> > endef
>
> > define DHCPDUMP_INSTALL_TARGET_CMDS
> > --
> > 1.7.1
>
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
>
next prev parent reply other threads:[~2015-10-21 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 14:05 [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Vicente Olivert Riera
2015-10-20 14:05 ` [Buildroot] [PATCH 2/3] dhcpdump: add project URL Vicente Olivert Riera
2015-10-20 20:19 ` Peter Korsgaard
2015-10-20 20:23 ` Peter Korsgaard
2015-10-20 14:05 ` [Buildroot] [PATCH 3/3] dhcpdump: add a hash file Vicente Olivert Riera
2015-10-20 20:22 ` Peter Korsgaard
2015-10-20 20:18 ` [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Peter Korsgaard
2015-10-21 9:20 ` Vicente Olivert Riera [this message]
2015-10-21 20:11 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562758C4.1010903@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.