From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45054)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Yongbok.Kim@imgtec.com>) id 1ZowFN-0001l5-Sh
	for qemu-devel@nongnu.org; Wed, 21 Oct 2015 12:28:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Yongbok.Kim@imgtec.com>) id 1ZowFK-0004YK-Lz
	for qemu-devel@nongnu.org; Wed, 21 Oct 2015 12:28:17 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:27569)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Yongbok.Kim@imgtec.com>) id 1ZowFK-0004Xm-GD
	for qemu-devel@nongnu.org; Wed, 21 Oct 2015 12:28:14 -0400
References: <1444953129-35040-1-git-send-email-yongbok.kim@imgtec.com>
	<CAFEAcA-pk6CEVMPpC03wUhg9Ui933xW4LSYB=hJGjRVSj5F=Mg@mail.gmail.com>
From: Yongbok Kim <yongbok.kim@imgtec.com>
Message-ID: <5627BD19.6090401@imgtec.com>
Date: Wed, 21 Oct 2015 17:28:09 +0100
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-pk6CEVMPpC03wUhg9Ui933xW4LSYB=hJGjRVSj5F=Mg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/4] mips: add Global Interrupt Controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Leon Alrae <leon.alrae@imgtec.com>, QEMU Developers <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>

On 21/10/2015 17:01, Peter Maydell wrote:
> On 16 October 2015 at 00:52, Yongbok Kim <yongbok.kim@imgtec.com> wrote:
>> Add support of MIPS GIC.
>>
>>  hw/mips/Makefile.objs        |    2 +-
>>  hw/mips/mips_gcr.c           |  120 ++++++++
>>  hw/mips/mips_gcr.h           |   57 ++++
>>  hw/mips/mips_gic.c           |  653 ++++++++++++++++++++++++++++++++++++++++++
>>  hw/mips/mips_gic.h           |  298 +++++++++++++++++++
>>  hw/mips/mips_malta.c         |   71 +++++-
>>  target-mips/cpu.h            |    4 +-
>>  target-mips/translate.c      |   17 ++
>>  target-mips/translate_init.c |    3 +-
>>  9 files changed, 1220 insertions(+), 5 deletions(-)
>>  create mode 100644 hw/mips/mips_gcr.c
>>  create mode 100644 hw/mips/mips_gcr.h
>>  create mode 100644 hw/mips/mips_gic.c
>>  create mode 100644 hw/mips/mips_gic.h
> 
> Should this live in hw/intc/ if it is an interrupt controller?
> 
> thanks
> -- PMM
> 

Actually I have considered that but I just hesitated to put the files in
the hw/intc as all other MIPS related hw component files are in hw/mips. I
agree with your opinion. From the v2 the mips_gic.{c|h} files will be in
the directory. I think the mips_gcr.{c|h} is quite MIPS specific and it
doesn't fit into any other directory than hw/mips.

Regards,
Yongbok