Re: merge struct ib_device_attr into struct ib_device V2

[Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>]

On 10/21/2015 11:43 AM, Jason Gunthorpe wrote:
> On Wed, Oct 21, 2015 at 08:48:10AM -0700, Bart Van Assche wrote:
>> On 10/21/2015 12:11 AM, Or Gerlitz wrote:
>>> haven't found any review or ack to your giant patch that touches the
>>> whole subsystem (drivers, core and ULPs) expect from Sagi's -- lets
>>> hear more opinions.
>> Although I have not yet had the time to review the entire patch, removing
>> ib_query_device() seems a great idea to me and an idea that I welcome very
>> much. The ib_device_attr structure is too large to be allocated on the
>> stack. This means that with Christoph's patch it is no longer needed to call
>> kmalloc() + ib_query_device() + kfree() when a device attribute is needed
>> from kernel code.
> I agree, this is absolutely the right way to go.
>
> The bikeshedding is not important, nobody has come up with a reason
> why we need to maintain the attr structure as-is and Christoph already
> has a patch - I say go with it.
>
> Jason
>

While I don't really like the uber patch review-wise, I'm all for nuking 
ib_query_device() and the attr struct.

Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html