From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 1/5] sockets: remove use of QemuOpts from header file
Date: Wed, 21 Oct 2015 11:23:05 -0600 [thread overview]
Message-ID: <5627C9F9.1020009@redhat.com> (raw)
In-Reply-To: <1445442218-32183-2-git-send-email-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On 10/21/2015 09:43 AM, Daniel P. Berrange wrote:
> There are no callers of the sockets methods which accept
> QemuOpts any more. Make all the QemuOpts related functions
> static to avoid new callers being added, in preparation
> for removal of all QemuOpts usage, in favour of QAPI
> SocketAddress.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> include/qemu/sockets.h | 9 ---------
> util/qemu-sockets.c | 22 +++++++++++-----------
> 2 files changed, 11 insertions(+), 20 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-21 17:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 15:43 [Qemu-devel] [PATCH v1 0/5] Convert qemu-socket to use QAPI exclusively Daniel P. Berrange
2015-10-21 15:43 ` [Qemu-devel] [PATCH v1 1/5] sockets: remove use of QemuOpts from header file Daniel P. Berrange
2015-10-21 17:23 ` Eric Blake [this message]
2015-10-21 15:43 ` [Qemu-devel] [PATCH v1 2/5] sockets: remove use of QemuOpts from socket_listen Daniel P. Berrange
2015-10-21 15:54 ` Paolo Bonzini
2015-10-21 16:49 ` Daniel P. Berrange
2015-10-21 15:43 ` [Qemu-devel] [PATCH v1 3/5] sockets: remove use of QemuOpts from socket_connect Daniel P. Berrange
2015-10-21 15:43 ` [Qemu-devel] [PATCH v1 4/5] sockets: remove use of QemuOpts from socket_dgram Daniel P. Berrange
2015-10-21 15:43 ` [Qemu-devel] [PATCH v1 5/5] vnc: distiguish between ipv4/ipv6 omitted vs set to off Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5627C9F9.1020009@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.