Re: [PATCH] apparmor: clarify CRYPTO dependency

[John Johansen <john.johansen@canonical.com>]

On 10/21/2015 12:16 PM, Arnd Bergmann wrote:
> The crypto framework can be built as a loadable module, but the
> apparmor hash code can only be built-in, which then causes a
> link error:
> 
> security/built-in.o: In function `aa_calc_profile_hash':
> integrity_audit.c:(.text+0x21610): undefined reference to `crypto_shash_update'
> security/built-in.o: In function `init_profile_hash':
> integrity_audit.c:(.init.text+0xb4c): undefined reference to `crypto_alloc_shash'
> 
> This changes Apparmor to use 'select CRYPTO' like a lot of other
> subsystems do.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
thanks

Acked-by: John Johansen <john.johansen@canonical.com>

> 
> diff --git a/security/apparmor/Kconfig b/security/apparmor/Kconfig
> index d49c53960b60..232469baa94f 100644
> --- a/security/apparmor/Kconfig
> +++ b/security/apparmor/Kconfig
> @@ -33,7 +33,7 @@ config SECURITY_APPARMOR_BOOTPARAM_VALUE
>  config SECURITY_APPARMOR_HASH
>  	bool "SHA1 hash of loaded profiles"
>  	depends on SECURITY_APPARMOR
> -	depends on CRYPTO
> +	select CRYPTO
>  	select CRYPTO_SHA1
>  	default y
>  
>