All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: tegra: enable PCI support of p2371-2180
Date: Wed, 21 Oct 2015 19:51:23 -0600	[thread overview]
Message-ID: <5628411B.1070500@wwwdotorg.org> (raw)
In-Reply-To: <aa5a3d6c55b9497ab0085fa7f5e5b012@HQMAIL103.nvidia.com>

On 10/21/2015 05:24 PM, Tom Warren wrote:
>Stephen Warren wrote at Wednesday, October 21, 2015 4:11 PM:
>> On 10/21/2015 05:03 PM, Tom Warren wrote:
>>> Stephen,
>>>
>>>Stephen Warren wrote at Monday, October 05, 2015 4:03 PM:
>>>> p2371-2180 has two PCI ports; a regular x4 slot and a x1 M.2 slot.
>>>> This patch adds the relevant DT to enable the PCI controller and
>>>> configure the XUSB padctl pin muxing, and code to turn on the PCI
>>>> power and enable PCI features in U- Boot. I have only tested the x4 slot.
>>>>
>>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>>>
>>> This breaks the P2371-2180 build with this error:
>>>
>>> drivers/net/rtl8169.c: In function 'rtl_recv':
>>> drivers/net/rtl8169.c:584:25: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
>>>    return rtl_recv_common((pci_dev_t)dev->priv, dev->iobase, NULL);
>>>                           ^
>>> drivers/net/rtl8169.c: In function 'rtl_send':
>>> drivers/net/rtl8169.c:669:25: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
>>>    return rtl_send_common((pci_dev_t)dev->priv, dev->iobase, packet,
>>>                           ^
>>> drivers/net/rtl8169.c: In function 'rtl_reset':
>>> drivers/net/rtl8169.c:849:23: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
>>>    rtl8169_common_start((pci_dev_t)dev->priv, dev->enetaddr);
>>>
>>> I've taken my current u-boot-tegra/master, rebased against u-boot/master,
>> added your armv8 NONCACHED_MEMORY patchset, then your PLLE, XUSB and
>> PCI patchsets. Here are the top commits:
>> ...
>>
>> You're missing the following two:
>>
>> net: rtl8169: Build warning fixes for 64-bit
>> fdt: fix fdtdec_get_pci_addr() for CONFIG_PHYS_64BIT
>
> Actually the 'net: rtl8169' patch is in there (brought in from my rebase w/u-boot/master this morning), but the 'fix fdtdec_get_pci_addr' patch isn't. Looks like it is assigned to Simon in Patchwork, and hasn't been applied yet (as of when I pulled down u-boot/master several hours ago). I'll check again, and apply it myself to get the build working if needed so I can do some testing.

You're probably seeing this one from Thierry:
744152f8cf42 net: rtl8169: Build warning fixes for 64-bit

Some additional warnings were introduced by some other commit since he
wrote that. Unfortunately it looks like I the fix I wrote for that used
the same subject line; sorry about that. My patch is:

http://patchwork.ozlabs.org/patch/525854/
net: rtl8169: Build warning fixes for 64-bit

  reply	other threads:[~2015-10-22  1:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 23:02 [U-Boot] [PATCH 1/2] ARM: tegra: add PCI to Tegra210 SoC DT Stephen Warren
2015-10-05 23:02 ` [U-Boot] [PATCH 2/2] ARM: tegra: enable PCI support of p2371-2180 Stephen Warren
2015-10-21 23:03   ` Tom Warren
2015-10-21 23:10     ` Stephen Warren
2015-10-21 23:24       ` Tom Warren
2015-10-22  1:51         ` Stephen Warren [this message]
2015-10-21 16:42 ` [U-Boot] [PATCH 1/2] ARM: tegra: add PCI to Tegra210 SoC DT Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5628411B.1070500@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.