From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH 1/3] dt-bindings: Add document of Rockchip mailbox Date: Thu, 22 Oct 2015 10:07:00 +0800 Message-ID: <562844C4.5040304@gmail.com> References: <1442228798-15191-1-git-send-email-wxt@rock-chips.com> <1442228798-15191-2-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jassi Brar Cc: Caesar Wang , Mark Rutland , Devicetree List , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Pawel Moll , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Catalin Marinas , Will Deacon , Linux Kernel Mailing List , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Kumar Gala , "olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-rockchip.vger.kernel.org Hello Jassi, Sorry for delay reply. =E5=9C=A8 2015=E5=B9=B410=E6=9C=8806=E6=97=A5 18:34, Jassi Brar =E5=86=99= =E9=81=93: > On Mon, Sep 14, 2015 at 4:36 PM, Caesar Wang wro= te: >> This add the necessary binding documentation for mailbox >> found on RK3368 SoC. >> >> Signed-off-by: Caesar Wang >> --- >> >> .../bindings/mailbox/rockchip-mailbox.txt | 33 ++++++++++= ++++++++++++ >> 1 file changed, 33 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mailbox/rockc= hip-mailbox.txt >> >> diff --git a/Documentation/devicetree/bindings/mailbox/rockchip-mail= box.txt b/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.tx= t >> new file mode 100644 >> index 0000000..b9b4768 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt >> @@ -0,0 +1,33 @@ >> +Rockchip mailbox >> + >> +The Rockchip mailbox is used by the Rockchip CPU cores to communica= te >> +requests to MCU processor. >> + >> +Refer to ./mailbox.txt for generic information about mailbox device= -tree >> +bindings. >> + >> +Required properties: >> + >> + - compatible: should be one of the following. >> + - "rockchip,rk3368-mbox" for rk3368 >> + - reg: physical base address of the controller and length of memor= y mapped >> + region. >> + physical base address of the share buffer and length of memo= ry mapped >> + region. > Please make shared-sram a property of user drivers. As Rob points out, maybe, don't we need also define it in user drivers. As the SRAM binding (misc/sram.txt) had defined. I just make the SCPI protocol client driver to work for mailbox. > > Location and size of shared-memory is a platform property, mailbox > controller doesn't need sram to function. > For example, protocol on some platform, with this controller, may = be > trivial enough to not need a shared sram... say only 32-bits wide > requests and responses which can be passed via mailbox registers > directly. mbox_client.tx_prepare() is where the user driver sets up > the shared-memory. > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip --=20 Thanks, Caesar -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: caesar.upstream@gmail.com (Caesar Wang) Date: Thu, 22 Oct 2015 10:07:00 +0800 Subject: [PATCH 1/3] dt-bindings: Add document of Rockchip mailbox In-Reply-To: References: <1442228798-15191-1-git-send-email-wxt@rock-chips.com> <1442228798-15191-2-git-send-email-wxt@rock-chips.com> Message-ID: <562844C4.5040304@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Jassi, Sorry for delay reply. ? 2015?10?06? 18:34, Jassi Brar ??: > On Mon, Sep 14, 2015 at 4:36 PM, Caesar Wang wrote: >> This add the necessary binding documentation for mailbox >> found on RK3368 SoC. >> >> Signed-off-by: Caesar Wang >> --- >> >> .../bindings/mailbox/rockchip-mailbox.txt | 33 ++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt >> >> diff --git a/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt b/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt >> new file mode 100644 >> index 0000000..b9b4768 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt >> @@ -0,0 +1,33 @@ >> +Rockchip mailbox >> + >> +The Rockchip mailbox is used by the Rockchip CPU cores to communicate >> +requests to MCU processor. >> + >> +Refer to ./mailbox.txt for generic information about mailbox device-tree >> +bindings. >> + >> +Required properties: >> + >> + - compatible: should be one of the following. >> + - "rockchip,rk3368-mbox" for rk3368 >> + - reg: physical base address of the controller and length of memory mapped >> + region. >> + physical base address of the share buffer and length of memory mapped >> + region. > Please make shared-sram a property of user drivers. As Rob points out, maybe, don't we need also define it in user drivers. As the SRAM binding (misc/sram.txt) had defined. I just make the SCPI protocol client driver to work for mailbox. > > Location and size of shared-memory is a platform property, mailbox > controller doesn't need sram to function. > For example, protocol on some platform, with this controller, may be > trivial enough to not need a shared sram... say only 32-bits wide > requests and responses which can be passed via mailbox registers > directly. mbox_client.tx_prepare() is where the user driver sets up > the shared-memory. > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Thanks, Caesar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756563AbbJVCHS (ORCPT ); Wed, 21 Oct 2015 22:07:18 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:36346 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753405AbbJVCHQ (ORCPT ); Wed, 21 Oct 2015 22:07:16 -0400 Subject: Re: [PATCH 1/3] dt-bindings: Add document of Rockchip mailbox To: Jassi Brar References: <1442228798-15191-1-git-send-email-wxt@rock-chips.com> <1442228798-15191-2-git-send-email-wxt@rock-chips.com> Cc: Caesar Wang , Mark Rutland , Devicetree List , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Pawel Moll , "ijc+devicetree@hellion.org.uk" , frank.wang@rock-chips.com, Catalin Marinas , Will Deacon , Linux Kernel Mailing List , linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , "olof@lixom.net" , "linux-arm-kernel@lists.infradead.org" From: Caesar Wang Message-ID: <562844C4.5040304@gmail.com> Date: Thu, 22 Oct 2015 10:07:00 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jassi, Sorry for delay reply. 在 2015年10月06日 18:34, Jassi Brar 写道: > On Mon, Sep 14, 2015 at 4:36 PM, Caesar Wang wrote: >> This add the necessary binding documentation for mailbox >> found on RK3368 SoC. >> >> Signed-off-by: Caesar Wang >> --- >> >> .../bindings/mailbox/rockchip-mailbox.txt | 33 ++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt >> >> diff --git a/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt b/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt >> new file mode 100644 >> index 0000000..b9b4768 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt >> @@ -0,0 +1,33 @@ >> +Rockchip mailbox >> + >> +The Rockchip mailbox is used by the Rockchip CPU cores to communicate >> +requests to MCU processor. >> + >> +Refer to ./mailbox.txt for generic information about mailbox device-tree >> +bindings. >> + >> +Required properties: >> + >> + - compatible: should be one of the following. >> + - "rockchip,rk3368-mbox" for rk3368 >> + - reg: physical base address of the controller and length of memory mapped >> + region. >> + physical base address of the share buffer and length of memory mapped >> + region. > Please make shared-sram a property of user drivers. As Rob points out, maybe, don't we need also define it in user drivers. As the SRAM binding (misc/sram.txt) had defined. I just make the SCPI protocol client driver to work for mailbox. > > Location and size of shared-memory is a platform property, mailbox > controller doesn't need sram to function. > For example, protocol on some platform, with this controller, may be > trivial enough to not need a shared sram... say only 32-bits wide > requests and responses which can be passed via mailbox registers > directly. mbox_client.tx_prepare() is where the user driver sets up > the shared-memory. > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Thanks, Caesar