From: Paolo Bonzini <pbonzini@redhat.com>
To: Jordan Justen <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
qemu-devel@nongnu.org
Cc: Michael Kinney <michael.d.kinney@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT
Date: Thu, 22 Oct 2015 10:40:08 +0200 [thread overview]
Message-ID: <5628A0E8.8050705@redhat.com> (raw)
In-Reply-To: <20151021183625.26940.67906@jljusten-ivb>
On 21/10/2015 20:36, Jordan Justen wrote:
> On 2015-10-20 11:14:00, Laszlo Ersek wrote:
> > Commit 4d00636e97b7 ("ich9: Add the lpc chip", Nov 14 2012) added the
> > ich9_apm_ctrl_changed() ioport write callback function such that it would
> > inject the SMI, in response to a write to the APM_CNT register, on the
> > first CPU, invariably.
> >
> > Since this register is used by guest code to trigger an SMI synchronously,
> > the interrupt should be injected on the VCPU that is performing the write.
>
> Why not send an SMI to *all* processors, like the real chipsets do?
That's much less scalable, and more important I would have to check that
SeaBIOS can handle that correctly. It probably doesn't, as it doesn't
relocate SMBASEs.
Paolo
next prev parent reply other threads:[~2015-10-22 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 18:14 [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT Laszlo Ersek
2015-10-21 9:49 ` Paolo Bonzini
2015-10-21 10:29 ` Michael S. Tsirkin
2015-10-21 18:36 ` Jordan Justen
2015-10-22 8:40 ` Paolo Bonzini [this message]
2015-10-22 9:50 ` Laszlo Ersek
2015-10-22 9:54 ` Paolo Bonzini
2015-10-22 18:04 ` Kevin O'Connor
2015-10-22 19:46 ` Paolo Bonzini
2015-10-23 4:41 ` Jordan Justen
2015-10-23 7:26 ` Paolo Bonzini
2015-10-23 12:53 ` Laszlo Ersek
2015-10-23 18:20 ` Jordan Justen
2015-10-23 18:24 ` Paolo Bonzini
2015-10-23 21:25 ` Laszlo Ersek
2015-10-23 16:54 ` Kevin O'Connor
2015-10-23 17:00 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5628A0E8.8050705@redhat.com \
--to=pbonzini@redhat.com \
--cc=jordan.l.justen@intel.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=michael.d.kinney@intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.