From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: Task for OPW
Date: Thu, 22 Oct 2015 12:37:40 +0100
Message-ID: <5628CA84.2010901@citrix.com>
References: <CAAbK428w8fuXDwXc9txykSVse45BU9g_v+xRDR6_RJSU=cdjWQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAAbK428w8fuXDwXc9txykSVse45BU9g_v+xRDR6_RJSU=cdjWQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Lasya Venneti <comethalley61@gmail.com>, xen-devel@lists.xen.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 22/10/15 12:29, Lasya Venneti wrote:
> Hello :-)
> 
> Could you please give me a small task I can complete for Outreachy/OPW,
> before the deadline?

In xen/common/sched_credit.c there's a function named __runq_insert()
which takes two arguments: cpu and svc.

However, the cpu argument is redundant: you can get all the information
you need from svc.

Submit a (tested) patch which removes cpu as an argument to the function
but has the same functionality.

You can find a lot of practical advice about how to send patches with
git here:

http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches

I generally recommend using stg to actually manage your patch series:

http://wiki.xenproject.org/wiki/Submitting_Xen_Patches_with_StGit

But be sure to read the first one as well, as it contains lots of extra
information about what makes a good patch, the Signed-off-by: line, and
so on.

Thanks,
 -George