Re: [Qemu-devel] [PATCH] qapi-schema: mark InetSocketAddress as mandatory again

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

On 10/22/2015 06:42 AM, Daniel P. Berrange wrote:

>>> +++ b/qapi-schema.json
>>> @@ -2614,9 +2614,7 @@
>>>  #
>>>  # @host: host part of the address
>>>  #
>>> -# @port: port part of the address, or lowest port if @to is present.
>>> -#        Kernel selects a free port if omitted for listener addresses.
>>> -#        #optional
>>> +# @port: port part of the address, or lowest port if @to is present
>>
>> Don't you still want to allow an empty string as the way to allow kernel
>> port selection?
> 
> I only needed the support for empty port for the sake of the unit
> tests, which doesn't use QAPI parsing code. Enabling it via the command
> line / monitor was just a happy accident, so I figure this is fine for
> 2.5. We can re-revert it in 2.6 when you change the QAPI generator

Fair enough; then you can add:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]