All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>, Eryu Guan <eguan@redhat.com>
Cc: fstests <fstests@vger.kernel.org>, Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH 2/2] dm-thinp demo test
Date: Thu, 22 Oct 2015 09:36:07 -0500	[thread overview]
Message-ID: <5628F457.7020605@redhat.com> (raw)
In-Reply-To: <5628EF2A.3020604@sandeen.net>

On 10/22/15 9:14 AM, Eric Sandeen wrote:
>>> +_workout
>>> >> +_dmthin_check_fs
>> > 
>> > btrfs fails the fs check, because btrfs changes lv device name in df
>> > output, from /dev/mapper/xxx to /dev/dm-x, so _check_scratch_fs couldn't
>> > umount it and btrfsck runs on mounted btrfs.
> Huh, weird.  I'll admit that I did not test btrfs.  Other filesystems
> worked for you?  I'm not sure how btrfs can change df output...
> 
> mapper symlinks have been a constant source of pain for fstests.  :(
> 
>> > Adding "$UMOUNT_PROG $SCRATCH_MNT" before _dmthin_check_fs is a
>> > workaround, though I think it's a btrfs issue.
> Hm, ok, thanks; easy enough to do that I guess.

ALthough, it seems to be working for me here; I do fail because btrfs
emits a warning in dmesg:

[215098.204612] BTRFS warning (device dm-6): Skipping commit of aborted transaction.
[215098.212074] ------------[ cut here ]------------
[215098.216794] WARNING: CPU: 3 PID: 19408 at fs/btrfs/transaction.c:1708 cleanup_transaction+0x86/0x2c0 [btrfs]()

which leads to:

_check_dmesg: something found in dmesg (see /mnt/test2/git/xfstests/results//generic/115.dmesg)
Ran: generic/115
Failures: generic/115

It's "just" a warning, though, so I'm not really sure this should be failing the test.

-Eric

  reply	other threads:[~2015-10-22 14:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 20:48 [PATCH 0/2] dm-thinp helpers and demo test Eric Sandeen
2015-10-21 20:53 ` [PATCH 1/2] dm-thinp helpers in common/dmthin Eric Sandeen
2016-02-05  3:57   ` Eryu Guan
2015-10-21 20:56 ` [PATCH 2/2] dm-thinp demo test Eric Sandeen
2015-10-22  9:47   ` Eryu Guan
2015-10-22 14:14     ` Eric Sandeen
2015-10-22 14:36       ` Eric Sandeen [this message]
     [not found]         ` <1454580261-29218-1-git-send-email-xzhou@redhat.com>
2016-02-05  3:58           ` [PATCH v2] fstests: " Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5628F457.7020605@redhat.com \
    --to=sandeen@redhat.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.