All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: George Dunlap <george.dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: xen/x86: Question about alloc_domheap_page in pod code
Date: Thu, 22 Oct 2015 16:04:45 +0100	[thread overview]
Message-ID: <5628FB0D.5070402@citrix.com> (raw)

Hi,

I was looking to the pod code (arch/x86/mm/p2m-pod.c) and noticed that
the calls to alloc_domheap_page{s,} seems to take wrong parameter:

page = alloc_domheap_pages(d, order, PAGE_ORDER_4K);

p = alloc_domheap_page(d, PAGE_ORDER_4K);

AFAICT the last parameter is the memory flags and not the order so using
PAGE_ORDER_4K is wrong. Am I right?

I don't know much x86, hence my question before sending a patch to fix it.

Regards,

-- 
Julien Grall

             reply	other threads:[~2015-10-22 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 15:04 Julien Grall [this message]
2015-10-22 15:10 ` xen/x86: Question about alloc_domheap_page in pod code Andrew Cooper
2015-10-22 15:17   ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5628FB0D.5070402@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.