All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@plumgrid.com>
To: "Wangnan (F)" <wangnan0@huawei.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	He Kuang <hekuang@huawei.com>, Kaixu Xia <xiakaixu@huawei.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper
Date: Thu, 22 Oct 2015 08:51:06 -0700	[thread overview]
Message-ID: <562905EA.2020101@plumgrid.com> (raw)
In-Reply-To: <562892C8.7030108@huawei.com>

On 10/22/15 12:39 AM, Wangnan (F) wrote:
>   ...
>   if (!perf_event_can_insert_to_map(attr))
>      ....
>
> Do you think redability is improved?

yes. makes sense. will respin.


  reply	other threads:[~2015-10-22 15:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 22:58 [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper Alexei Starovoitov
2015-10-22  4:49 ` Wangnan (F)
2015-10-22  5:00   ` Alexei Starovoitov
2015-10-22  5:30     ` Wangnan (F)
2015-10-22  5:31 ` Wangnan (F)
2015-10-22  6:21   ` Alexei Starovoitov
2015-10-22  7:39     ` Wangnan (F)
2015-10-22 15:51       ` Alexei Starovoitov [this message]
2015-10-22 12:30 ` Wangnan (F)
2015-10-22 12:41   ` Peter Zijlstra
2015-10-22 13:57 ` Peter Zijlstra
2015-10-22 15:53   ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562905EA.2020101@plumgrid.com \
    --to=ast@plumgrid.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hekuang@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wangnan0@huawei.com \
    --cc=xiakaixu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.