From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s} Date: Thu, 22 Oct 2015 17:13:14 +0100 Message-ID: <56290B1A.6030109@citrix.com> References: <1445528599-11895-1-git-send-email-julien.grall@citrix.com> <5629216C02000078000ADA46@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpIVn-0001Q2-Hu for xen-devel@lists.xenproject.org; Thu, 22 Oct 2015 16:14:43 +0000 In-Reply-To: <5629216C02000078000ADA46@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: George Dunlap , Andrew Cooper , Keir Fraser , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 22/10/15 16:48, Jan Beulich wrote: >>>> On 22.10.15 at 17:43, wrote: >> @@ -477,7 +477,7 @@ p2m_pod_offline_or_broken_replace(struct page_info *p) >> >> free_domheap_page(p); >> >> - p = alloc_domheap_page(d, PAGE_ORDER_4K); >> + p = alloc_domheap_page(d, 0); > > I realize that this is the easiest fix, but I think here we instead want > something like It sounds sensible to me to re-allocate the page on the same numa node. I will send another version of this patch. Although, I would appreciate if someone can test it because I don't have any NUMA platform. Regards, -- Julien Grall