From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpIv1-0005FO-70 for qemu-devel@nongnu.org; Thu, 22 Oct 2015 12:40:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpIuw-0001WD-Uh for qemu-devel@nongnu.org; Thu, 22 Oct 2015 12:40:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpIuw-0001W6-Pf for qemu-devel@nongnu.org; Thu, 22 Oct 2015 12:40:42 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2C83619CB93 for ; Thu, 22 Oct 2015 16:40:41 +0000 (UTC) References: <1444968943-11254-1-git-send-email-eblake@redhat.com> <1444968943-11254-16-git-send-email-eblake@redhat.com> <87r3knyoix.fsf@blackfin.pond.sub.org> <5628F21B.5050700@redhat.com> From: Eric Blake Message-ID: <56291182.7020907@redhat.com> Date: Thu, 22 Oct 2015 10:40:34 -0600 MIME-Version: 1.0 In-Reply-To: <5628F21B.5050700@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L332r4Ctvku775U5W7HQr24A5fjXVSgK4" Subject: Re: [Qemu-devel] [PATCH v9 15/17] tpm: Convert to new qapi union layout List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --L332r4Ctvku775U5W7HQr24A5fjXVSgK4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/22/2015 08:26 AM, Eric Blake wrote: >> PATCH 08-15 appear to be a purely mechanical switch to u. and from kin= d >> to type, except for a qapi.py hunk that looks like it should be in PAT= CH >> 07, and a comment update to tests/qapi-schema/union-clash-type.json. >> Did I miss anything? >> >> Combined diffstat isn't so bad: >> >> 36 files changed, 393 insertions(+), 394 deletions(-) >=20 > It already needs a rebase; some of Dan's work has caused more changes t= o > ui/vnc.c and util/qemu-sockets.c. So hopefully I post v10 soon. >=20 >> >> I've seen worse tree-wide changes, some of them my own. I'd be tempte= d >> to squash the complete switch together. But squashing is easy, so we >> can keep it separate while we review, and decide when we're done. >=20 > Sure, v10 will keep things separate, but squashing won't hurt too much.= > After all, v5 had it all as one patch. Just so I'm clear, if we wanted to squash, would it be just 8-15 (just the mechanical changes, but keeping the front-end scaffolding hack and backend cleanup, and keeping non-mechanical changes split off of 7 and 8 as a separate patch), or the entire 7-16 (no hack at all, and nothing to split off of 7 and 8)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --L332r4Ctvku775U5W7HQr24A5fjXVSgK4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWKRGDAAoJEKeha0olJ0NqsxQH/0JZr+LcUIM4Dou9O6Z9/1Rn m+PhBpeoVs6Tqu1AQTHnamwpXEHZq3jX+WbIal8PnTNANtattj5jtHX4o/vIPQ+Q IU7gMsL/zBF1rno7x/2ZRQcTyhFsgsZg8ATHQYdinssMbda5KDQompki/JP6GuSq mz4kN3LS966KCCpd6xXk6o9fnmbhRX92ZPmk8YlMWRJpqw2lzmxti7cJUwP4gzH6 q3jyzsLmb3Q10dUyWVDwNn89P9v6O23slt/R9s9fKMRGOLbgpAKm2XMjpw+/HZ26 19JeQA6IJ+Uhri5PTNjl/xGFAy7l61JyE9ZZaO7ezpEMFTk5RoFoTCsoQJvhS34= =eD/I -----END PGP SIGNATURE----- --L332r4Ctvku775U5W7HQr24A5fjXVSgK4--