From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xl: log an error if libxl_cpupool_destroy()
	fails
Date: Fri, 23 Oct 2015 06:21:52 +0200
Message-ID: <5629B5E0.4060600@suse.com>
References: <20151022171420.15122.92760.stgit@Solace.station>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <jgross@suse.com>) id 1ZpTrY-0005Gi-FO
	for xen-devel@lists.xenproject.org; Fri, 23 Oct 2015 04:21:56 +0000
In-Reply-To: <20151022171420.15122.92760.stgit@Solace.station>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 10/22/2015 07:14 PM, Dario Faggioli wrote:
> In fact, right now, failing at destroying a cpupool is just
> not reported to the user in any explicit way. Log an error,
> as it is customary for xl in these cases.
>
> While there, take the chance to turn a couple of xl exit
> codes into EXIT_[SUCCESS|FAILURE], as discussed and agreed
> here:
>
>   http://lists.xenproject.org/archives/html/xen-devel/2015-03/msg01336.html
>   http://lists.xenproject.org/archives/html/xen-devel/2015-03/msg01341.html
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Juergen Gross <jgross@suse.com>
> ---
>   tools/libxl/xl_cmdimpl.c |   10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 365798b..5a5f959 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -7581,13 +7581,15 @@ int main_cpupooldestroy(int argc, char **argv)
>       if (libxl_cpupool_qualifier_to_cpupoolid(ctx, pool, &poolid, NULL) ||
>           !libxl_cpupoolid_is_valid(ctx, poolid)) {
>           fprintf(stderr, "unknown cpupool '%s'\n", pool);
> -        return 1;
> +        return EXIT_FAILURE;
>       }
>
> -    if (libxl_cpupool_destroy(ctx, poolid))
> -        return 1;
> +    if (libxl_cpupool_destroy(ctx, poolid)) {
> +        fprintf(stderr, "Can't destroy cpupool '%s'\n", pool);
> +        return EXIT_FAILURE;
> +    }
>
> -    return 0;
> +    return EXIT_SUCCESS;
>   }
>
>   int main_cpupoolrename(int argc, char **argv)
>
>