From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Elf Subject: Re: [PATCH v2 7/8] drm/i915: Grab execlist spinlock to avoid post-reset concurrency issues. Date: Fri, 23 Oct 2015 12:02:47 +0100 Message-ID: <562A13D7.9030609@intel.com> References: <1444329100-19189-8-git-send-email-tomas.elf@intel.com> <1445268752-19155-1-git-send-email-tomas.elf@intel.com> <5629F2F3.2000308@linux.intel.com> <20151023085951.GL16848@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 14DDF6EFBA for ; Fri, 23 Oct 2015 04:02:50 -0700 (PDT) In-Reply-To: <20151023085951.GL16848@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Tvrtko Ursulin Cc: "Intel-GFX@Lists.FreeDesktop.Org" List-Id: intel-gfx@lists.freedesktop.org T24gMjMvMTAvMjAxNSAwOTo1OSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBGcmksIE9jdCAy MywgMjAxNSBhdCAwOTo0MjoyN0FNICswMTAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4KPj4g T24gMTkvMTAvMTUgMTY6MzIsIFRvbWFzIEVsZiB3cm90ZToKPj4+IEdyYWIgZXhlY2xpc3QgbG9j ayB3aGVuIGNsZWFuaW5nIHVwIGV4ZWNsaXN0IHF1ZXVlcyBhZnRlciBHUFUgcmVzZXQgdG8gYXZv aWQKPj4+IGNvbmN1cnJlbmN5IHByb2JsZW1zIGJldHdlZW4gdGhlIGNvbnRleHQgZXZlbnQgaW50 ZXJydXB0IGhhbmRsZXIgYW5kIHRoZSByZXNldAo+Pj4gcGF0aCBpbW1lZGlhdGVseSBmb2xsb3dp bmcgYSBHUFUgcmVzZXQuCj4+Pgo+Pj4gKiB2MiAoQ2hyaXMgV2lsc29uKToKPj4+IERvIGV4ZWNs aXN0IGNoZWNrIGFuZCB1c2Ugc2ltcGxlciBmb3JtIG9mIHNwaW5sb2NrIGZ1bmN0aW9ucy4KPj4+ Cj4+PiBTaWduZWQtb2ZmLWJ5OiBUb21hcyBFbGYgPHRvbWFzLmVsZkBpbnRlbC5jb20+Cj4+PiAt LS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8IDIzICsrKysrKysrKysr KysrLS0tLS0tLS0tCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCA5IGRl bGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+Pj4gaW5kZXggZTU3MDYx YS4uMmM3YTBiNyAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+IEBAIC0yNzUz LDE4ICsyNzUzLDIzIEBAIHN0YXRpYyB2b2lkIGk5MTVfZ2VtX3Jlc2V0X3JpbmdfY2xlYW51cChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+PiAgIAkgKiBhcmUgdGhlIG9uZXMg dGhhdCBrZWVwIHRoZSBjb250ZXh0IGFuZCByaW5nYnVmZmVyIGJhY2tpbmcgb2JqZWN0cwo+Pj4g ICAJICogcGlubmVkIGluIHBsYWNlLgo+Pj4gICAJICovCj4+PiAtCXdoaWxlICghbGlzdF9lbXB0 eSgmcmluZy0+ZXhlY2xpc3RfcXVldWUpKSB7Cj4+PiAtCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3Jl cXVlc3QgKnN1Ym1pdF9yZXE7Cj4+Pgo+Pj4gLQkJc3VibWl0X3JlcSA9IGxpc3RfZmlyc3RfZW50 cnkoJnJpbmctPmV4ZWNsaXN0X3F1ZXVlLAo+Pj4gLQkJCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3Jl cXVlc3QsCj4+PiAtCQkJCWV4ZWNsaXN0X2xpbmspOwo+Pj4gLQkJbGlzdF9kZWwoJnN1Ym1pdF9y ZXEtPmV4ZWNsaXN0X2xpbmspOwo+Pj4gKwlpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzKSB7Cj4+ PiArCQlzcGluX2xvY2tfaXJxKCZyaW5nLT5leGVjbGlzdF9sb2NrKTsKPj4+ICsJCXdoaWxlICgh bGlzdF9lbXB0eSgmcmluZy0+ZXhlY2xpc3RfcXVldWUpKSB7Cj4+PiArCQkJc3RydWN0IGRybV9p OTE1X2dlbV9yZXF1ZXN0ICpzdWJtaXRfcmVxOwo+Pj4KPj4+IC0JCWlmIChzdWJtaXRfcmVxLT5j dHggIT0gcmluZy0+ZGVmYXVsdF9jb250ZXh0KQo+Pj4gLQkJCWludGVsX2xyX2NvbnRleHRfdW5w aW4oc3VibWl0X3JlcSk7Cj4+PiArCQkJc3VibWl0X3JlcSA9IGxpc3RfZmlyc3RfZW50cnkoJnJp bmctPmV4ZWNsaXN0X3F1ZXVlLAo+Pj4gKwkJCQkJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0 LAo+Pj4gKwkJCQkJZXhlY2xpc3RfbGluayk7Cj4+PiArCQkJbGlzdF9kZWwoJnN1Ym1pdF9yZXEt PmV4ZWNsaXN0X2xpbmspOwo+Pj4KPj4+IC0JCWk5MTVfZ2VtX3JlcXVlc3RfdW5yZWZlcmVuY2Uo c3VibWl0X3JlcSk7Cj4+PiArCQkJaWYgKHN1Ym1pdF9yZXEtPmN0eCAhPSByaW5nLT5kZWZhdWx0 X2NvbnRleHQpCj4+PiArCQkJCWludGVsX2xyX2NvbnRleHRfdW5waW4oc3VibWl0X3JlcSk7Cj4+ PiArCj4+PiArCQkJaTkxNV9nZW1fcmVxdWVzdF91bnJlZmVyZW5jZShzdWJtaXRfcmVxKTsKPj4+ ICsJCX0KPj4+ICsJCXNwaW5fdW5sb2NrX2lycSgmcmluZy0+ZXhlY2xpc3RfbG9jayk7Cj4+Cj4+ IENhbid0IHRoaXMsIGluIHRoZW9yeSBhdCBsZWFzdCwgZW5kIHVwIGNhbGxpbmcgZHJtX2dlbV9v YmplY3RfdW5yZWZlcmVuY2UgaW4KPj4gYSBjb3VwbGUgb2YgY29kZSBwYXRocywgd2hpY2ggY2Fu IHNsZWVwLCB3aGlsZSBob2xkaW5nIGEgc3BpbmxvY2s/Cj4+Cj4+IElmIHRoaXMgY2Fubm90IGhh cHBlbiBpbiBwcmFjdGljZSBmb3Igc29tZSByZWFzb24gaXQgd291bGQgcHJvYmFibHkgYmUgZ29v ZAo+PiB0byBwdXQgYSBjb21tZW50IGV4cGxhaW5pbmcgaXQuCj4+Cj4+IE9yIEkgYW0gbWlzc2lu ZyBzb21ldGhpbmc/Cj4KPiBJdCBjYW4gaW5kZWVkIEkgdGhpbmsuIFR2cnRrbywgc2luY2UgSSdt IG9mZiB0byBLUyBuZXh0IHdlZWsgYW5kIHlvdSBoYXZlCj4gcHVzaCBhY2Nlc3MsIGNhbiB5b3Ug cGxzIHB1c2ggdGhlIHJldmVydCBpZiB0aGlzIGNoZWNrcyBvdXQ/CgpJJ3ZlIGRpc2N1c3NlZCBp dCB3aXRoIFR2cnRrbyBhbmQgb25lIHNvbHV0aW9uIHRoYXQgc2VlbXMgcmVhc29uYWJsZSBpcyAK dG8gaG9sZCB0aGUgZXhlY2xpc3QgbG9jayB3aGlsZSB0cmF2ZXJzaW5nIHRoZSBleGVjbGlzdCBx dWV1ZSBhbmQgbW92aW5nIAp0aGUgZWxlbWVudHMgb3ZlciB0byBhIHRlbXBvcmFyeSBsaXN0LiBB ZnRlciB0aGF0IHdlIGNhbiBkcm9wIHRoZSAKZXhlY2xpc3QgbG9jaywgdHJhdmVyc2UgdGhlIHRl bXBvcmFyeSBsaXN0IGFuZCB1bnJlZmVyZW5jZSB0aGUgZWxlbWVudHMgCndoaWxlIG5vdCBob2xk aW5nIGxvY2suIFRoYXQgd2F5IHdlIGNhbiBnZXQgcmlkIG9mIHRoZSBlbGVtZW50IGluIGEgCnN5 bmNocm9uaXplZCBmYXNoaW9uIGFuZCBhbHNvIHVucmVmZXJlbmNlIHdpdGhvdXQgaG9sZGluZyB0 aGUgbG9jay4gSSAKYmVsaWV2ZSB0aGlzIHBhdHRlcm4gaXMgdXNlZCBlbHNld2hlcmUgKHN1Y2gg YXMgZHVyaW5nIHJlcXVlc3QgcmV0aXJlbWVudCkKCkRvZXMgdGhhdCBzb3VuZCBsaWtlIGEgcGxh biBvciBkb2VzIGFueW9uZSBoYXZlIGEgcHJvYmxlbSB3aXRoIHRoYXQgCnNvbHV0aW9uPwoKVGhh bmtzLApUb21hcwoKCj4KPiBUaGFua3MsIERhbmllbAo+CgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK