From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zpe6r-0005x5-9A for qemu-devel@nongnu.org; Fri, 23 Oct 2015 11:18:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zpe6n-0003ua-Ia for qemu-devel@nongnu.org; Fri, 23 Oct 2015 11:18:25 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:40322 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zpe6n-0003uU-5V for qemu-devel@nongnu.org; Fri, 23 Oct 2015 11:18:21 -0400 Message-ID: <562A4FB9.5070501@kamp.de> Date: Fri, 23 Oct 2015 17:18:17 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1444652845-20642-1-git-send-email-pl@kamp.de> <1444652845-20642-3-git-send-email-pl@kamp.de> <20151022162023.GB9156@stefanha-x1.localdomain> In-Reply-To: <20151022162023.GB9156@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] ide/atapi: blk_aio_readv may return NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, jcody@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Am 22.10.2015 um 18:20 schrieb Stefan Hajnoczi: > On Mon, Oct 12, 2015 at 02:27:23PM +0200, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> --- >> hw/ide/atapi.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c >> index 2271ea2..e0cf066 100644 >> --- a/hw/ide/atapi.c >> +++ b/hw/ide/atapi.c >> @@ -429,6 +429,10 @@ static void ide_atapi_cmd_read_dma_cb(void *opaque, int ret) >> s->bus->dma->aiocb = blk_aio_readv(s->blk, (int64_t)s->lba << 2, >> &s->bus->dma->qiov, n * 4, >> ide_atapi_cmd_read_dma_cb, s); >> + if (s->bus->dma->aiocb == NULL) { >> + ide_atapi_io_error(s, -EIO); >> + goto eot; >> + } > Where does blk_aio_readv() return NULL? Never. My fault. Peter