From: Bryan Huntsman <bryanh@codeaurora.org>
To: Stanimir Varbanov <svarbanov@mm-sol.com>,
Rob Clark <robdclark@gmail.com>,
linux-arm-msm@vger.kernel.org
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH] soc/qcom: add OCMEM driver
Date: Fri, 23 Oct 2015 10:52:33 -0700 [thread overview]
Message-ID: <562A73E1.5010701@codeaurora.org> (raw)
In-Reply-To: <562A2405.7070103@mm-sol.com>
On 10/23/2015 05:11 AM, Stanimir Varbanov wrote:
> Hi Rob,
...
>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>> index 266060b..b485043 100644
>> --- a/drivers/soc/qcom/Kconfig
>> +++ b/drivers/soc/qcom/Kconfig
>> @@ -74,3 +74,9 @@ config QCOM_WCNSS_CTRL
>> help
>> Client driver for the WCNSS_CTRL SMD channel, used to download nv
>> firmware to a newly booted WCNSS chip.
>> +
>> +config QCOM_OCMEM
>> + tristate "Qualcomm OCMEM driver"
>> + depends on QCOM_SMD
>
> Why this driver depends on SMD, I cannot see where smd is used here.
>
> Maybe depends on ARCH_QCOM should be sufficient?
AFAIK, Stan is correct. OCMEM should only be used by GPU w/o any of the
SMD stuff, so ARCH_QCOM looks better.
- Bryan
--
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-23 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 21:45 [PATCH] soc/qcom: add OCMEM driver Rob Clark
2015-10-23 12:11 ` Stanimir Varbanov
2015-10-23 17:52 ` Bryan Huntsman [this message]
2015-10-23 19:05 ` Rob Clark
-- strict thread matches above, loose matches on Subject: below --
2015-10-05 15:44 Rob Clark
2015-10-05 15:46 ` Rob Clark
2015-10-06 8:35 ` Stanimir Varbanov
2015-10-06 14:36 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562A73E1.5010701@codeaurora.org \
--to=bryanh@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sboyd@codeaurora.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.