diff for duplicates of <562A88D0.1010807@gmx.de> diff --git a/a/1.txt b/N1/1.txt index 951b8c7..b14bb03 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,42 +2,33 @@ On 22.10.2015 23:37, Tom Herbert wrote: > On Thu, Oct 22, 2015 at 1:00 PM, Helge Deller <deller@gmx.de> wrote: >> Hi Tom & David, >> ->> I've queued-up a patch for the parisc architecture which reduces L1_= -CACHE_BYTES from 32 to 16: +>> I've queued-up a patch for the parisc architecture which reduces L1_CACHE_BYTES from 32 to 16: >> https://patchwork.kernel.org/patch/7399291/ >> >> But this change will break the kernel build like this: >> >> In file included from net/core/dev.c:92:0: ->> net/core/dev.c: In function =E2=80=98expand_xps_map=E2=80=99: ->> include/linux/netdevice.h:721:27: warning: overflow in implicit cons= -tant conversion [-Woverflow] ->> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - sizeof(struct xps_ma= -p)) \ ->> net/core/dev.c:1972:18: note: in expansion of macro =E2=80=98XPS_MIN= -_MAP_ALLOC=E2=80=99 ->> int alloc_len =3D XPS_MIN_MAP_ALLOC; +>> net/core/dev.c: In function ‘expand_xps_map’: +>> include/linux/netdevice.h:721:27: warning: overflow in implicit constant conversion [-Woverflow] +>> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - sizeof(struct xps_map)) \ +>> net/core/dev.c:1972:18: note: in expansion of macro ‘XPS_MIN_MAP_ALLOC’ +>> int alloc_len = XPS_MIN_MAP_ALLOC; >> >> Do you see an easy way to fix this ? >> > How about ->=20 -> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - ((sizeof(struct xps_map= -) +> +> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - ((sizeof(struct xps_map) > % L1_CACHE_BYTES)) \ The full line would then be: -#define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - (sizeof(struct xps_map) % = -L1_CACHE_BYTES)) / sizeof(u16)) +#define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - (sizeof(struct xps_map) % L1_CACHE_BYTES)) / sizeof(u16)) -The only problem I see with this is, that XPS_MIN_MAP_ALLOC might becom= -e zero. -In that case the call to kzalloc_node() in expand_xps_map() doesn't all= -ocate any memory for the queues. +The only problem I see with this is, that XPS_MIN_MAP_ALLOC might become zero. +In that case the call to kzalloc_node() in expand_xps_map() doesn't allocate any memory for the queues. Helge -- -To unsubscribe from this list: send the line "unsubscribe linux-parisc"= - in +To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 7c4d78e..9ad6897 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -23,44 +23,35 @@ "> On Thu, Oct 22, 2015 at 1:00 PM, Helge Deller <deller@gmx.de> wrote:\n" ">> Hi Tom & David,\n" ">>\n" - ">> I've queued-up a patch for the parisc architecture which reduces L1_=\n" - "CACHE_BYTES from 32 to 16:\n" + ">> I've queued-up a patch for the parisc architecture which reduces L1_CACHE_BYTES from 32 to 16:\n" ">> https://patchwork.kernel.org/patch/7399291/\n" ">>\n" ">> But this change will break the kernel build like this:\n" ">>\n" ">> In file included from net/core/dev.c:92:0:\n" - ">> net/core/dev.c: In function =E2=80=98expand_xps_map=E2=80=99:\n" - ">> include/linux/netdevice.h:721:27: warning: overflow in implicit cons=\n" - "tant conversion [-Woverflow]\n" - ">> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - sizeof(struct xps_ma=\n" - "p)) \\\n" - ">> net/core/dev.c:1972:18: note: in expansion of macro =E2=80=98XPS_MIN=\n" - "_MAP_ALLOC=E2=80=99\n" - ">> int alloc_len =3D XPS_MIN_MAP_ALLOC;\n" + ">> net/core/dev.c: In function \342\200\230expand_xps_map\342\200\231:\n" + ">> include/linux/netdevice.h:721:27: warning: overflow in implicit constant conversion [-Woverflow]\n" + ">> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - sizeof(struct xps_map)) \\\n" + ">> net/core/dev.c:1972:18: note: in expansion of macro \342\200\230XPS_MIN_MAP_ALLOC\342\200\231\n" + ">> int alloc_len = XPS_MIN_MAP_ALLOC;\n" ">>\n" ">> Do you see an easy way to fix this ?\n" ">>\n" "> How about\n" - ">=20\n" - "> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - ((sizeof(struct xps_map=\n" - ")\n" + "> \n" + "> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - ((sizeof(struct xps_map)\n" "> % L1_CACHE_BYTES)) \\\n" "\n" "The full line would then be:\n" - "#define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - (sizeof(struct xps_map) % =\n" - "L1_CACHE_BYTES)) / sizeof(u16))\n" + "#define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - (sizeof(struct xps_map) % L1_CACHE_BYTES)) / sizeof(u16))\n" "\n" - "The only problem I see with this is, that XPS_MIN_MAP_ALLOC might becom=\n" - "e zero.\n" - "In that case the call to kzalloc_node() in expand_xps_map() doesn't all=\n" - "ocate any memory for the queues.\n" + "The only problem I see with this is, that XPS_MIN_MAP_ALLOC might become zero.\n" + "In that case the call to kzalloc_node() in expand_xps_map() doesn't allocate any memory for the queues.\n" "\n" "Helge\n" "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-parisc\"=\n" - " in\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-parisc\" in\n" "the body of a message to majordomo@vger.kernel.org\n" More majordomo info at http://vger.kernel.org/majordomo-info.html -c02ecc65faded7c61ecc1ecec5c54877097f90e4dc65a36a2b312bf6e32b306b +223a11a865ac16555d353ffd0aba045f162166c8f2dea76a093de7c61926feb4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.