diff for duplicates of <562A8990.9000808@gmx.de> diff --git a/a/1.txt b/N1/1.txt index bf0b4c7..f719f5b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,31 +2,26 @@ On 22.10.2015 23:50, Eric Dumazet wrote: > On Thu, 2015-10-22 at 22:00 +0200, Helge Deller wrote: >> Hi Tom & David, >> ->> I've queued-up a patch for the parisc architecture which reduces L1_= -CACHE_BYTES from 32 to 16: +>> I've queued-up a patch for the parisc architecture which reduces L1_CACHE_BYTES from 32 to 16: >> https://patchwork.kernel.org/patch/7399291/ >> >> But this change will break the kernel build like this: >> >> In file included from net/core/dev.c:92:0: ->> net/core/dev.c: In function =E2=80=98expand_xps_map=E2=80=99: ->> include/linux/netdevice.h:721:27: warning: overflow in implicit cons= -tant conversion [-Woverflow] ->> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - sizeof(struct xps_ma= -p)) \ ->> net/core/dev.c:1972:18: note: in expansion of macro =E2=80=98XPS_MIN= -_MAP_ALLOC=E2=80=99 ->> int alloc_len =3D XPS_MIN_MAP_ALLOC; +>> net/core/dev.c: In function ‘expand_xps_map’: +>> include/linux/netdevice.h:721:27: warning: overflow in implicit constant conversion [-Woverflow] +>> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - sizeof(struct xps_map)) \ +>> net/core/dev.c:1972:18: note: in expansion of macro ‘XPS_MIN_MAP_ALLOC’ +>> int alloc_len = XPS_MIN_MAP_ALLOC; >> >> Do you see an easy way to fix this ? ->=20 ->=20 +> +> > Using L2_CACHE_BYTES would be better, but it unfortunately does not > exist. Then, how about simply changing it to twice of L1_CACHE_BYTES ? -#define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES * 2 - sizeof(struct xps_map)= -) / sizeof(u16)) +#define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES * 2 - sizeof(struct xps_map)) / sizeof(u16)) Helge diff --git a/a/content_digest b/N1/content_digest index e244918..00c50fa 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -23,33 +23,28 @@ "> On Thu, 2015-10-22 at 22:00 +0200, Helge Deller wrote:\n" ">> Hi Tom & David,\n" ">>\n" - ">> I've queued-up a patch for the parisc architecture which reduces L1_=\n" - "CACHE_BYTES from 32 to 16:\n" + ">> I've queued-up a patch for the parisc architecture which reduces L1_CACHE_BYTES from 32 to 16:\n" ">> https://patchwork.kernel.org/patch/7399291/\n" ">>\n" ">> But this change will break the kernel build like this:\n" ">>\n" ">> In file included from net/core/dev.c:92:0:\n" - ">> net/core/dev.c: In function =E2=80=98expand_xps_map=E2=80=99:\n" - ">> include/linux/netdevice.h:721:27: warning: overflow in implicit cons=\n" - "tant conversion [-Woverflow]\n" - ">> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - sizeof(struct xps_ma=\n" - "p)) \\\n" - ">> net/core/dev.c:1972:18: note: in expansion of macro =E2=80=98XPS_MIN=\n" - "_MAP_ALLOC=E2=80=99\n" - ">> int alloc_len =3D XPS_MIN_MAP_ALLOC;\n" + ">> net/core/dev.c: In function \342\200\230expand_xps_map\342\200\231:\n" + ">> include/linux/netdevice.h:721:27: warning: overflow in implicit constant conversion [-Woverflow]\n" + ">> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - sizeof(struct xps_map)) \\\n" + ">> net/core/dev.c:1972:18: note: in expansion of macro \342\200\230XPS_MIN_MAP_ALLOC\342\200\231\n" + ">> int alloc_len = XPS_MIN_MAP_ALLOC;\n" ">>\n" ">> Do you see an easy way to fix this ?\n" - ">=20\n" - ">=20\n" + "> \n" + "> \n" "> Using L2_CACHE_BYTES would be better, but it unfortunately does not\n" "> exist.\n" "\n" "Then, how about simply changing it to twice of L1_CACHE_BYTES ?\n" "\n" - "#define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES * 2 - sizeof(struct xps_map)=\n" - ") / sizeof(u16))\n" + "#define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES * 2 - sizeof(struct xps_map)) / sizeof(u16))\n" "\n" Helge -3b58fd7eda4cd45e5e9cb2909a2319197f5de19bac71ca88c72f6de234dfd28d +792477571c6615ea1a16203d15bdcbf107de725899632c5cad3ff1664ef7d544
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.