From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shunqian Zheng Subject: Re: [PATCH v1 3/4] ASoC: Add codec machine driver for RK3036 Date: Sat, 24 Oct 2015 11:18:05 +0800 Message-ID: <562AF86D.8050303@rock-chips.com> References: <1444698070-4191-1-git-send-email-zhengsq@rock-chips.com> <1444698070-4191-4-git-send-email-zhengsq@rock-chips.com> <20151019191312.GQ32054@sirena.org.uk> Reply-To: zhengsq@rock-chips.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.134]) by alsa0.perex.cz (Postfix) with ESMTP id 6BBCC265388 for ; Sat, 24 Oct 2015 05:18:18 +0200 (CEST) In-Reply-To: <20151019191312.GQ32054@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org, heiko@sntech.de, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, tiwai@suse.com, lgirdwood@gmail.com, benzh@chromium.org, robh+dt@kernel.org, galak@codeaurora.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org TWFyayAmIFNqb2VyZCwKCk9uIDIwMTXlubQxMOaciDIw5pelIDAzOjEzLCBNYXJrIEJyb3duIHdy b3RlOgo+IE9uIFR1ZSwgT2N0IDEzLCAyMDE1IGF0IDA5OjAxOjA4QU0gKzA4MDAsIFNodW5xaWFu IFpoZW5nIHdyb3RlOgo+PiBGcm9tOiBaaGVuZ1NodW5RaWFuIDx6aGVuZ3NxQHJvY2stY2hpcHMu Y29tPgo+Pgo+PiBUaGlzIHBhdGNoIGFkZCB0aGUgbWFjaGluZSBkcml2ZXIgZm9yIHJrMzAzNi4K PiBMaWtlIFNqb2VyZCBzYWlkIHRoaXMgbG9va3MgbGlrZSBpdCBtaWdoIGJlIGJldHRlciBqdXN0 IHVzaW5nCj4gc2ltcGxlLWNhcmQsIGlmIG5vdC4uLgpZZXMsIHNpbXBsZS1jYXJkIHdvcmtzIGZp bmUsIEkgdGhpbmsgSSBuZWVkIHRvIGxlYXJuIG1vcmUgYW5kIHJlc2VuZCAKcGF0Y2hlcy4KClRo YW5rIHlvdSB2ZXJ5IG11Y2gsClNodW5xaWFuCj4KPj4gKwlyZXQgPSBzbmRfc29jX2RhaV9zZXRf Zm10KGNvZGVjX2RhaSwgZGFpX2ZtdCk7Cj4+ICsJaWYgKHJldCA8IDApCj4+ICsJCXJldHVybiBy ZXQ7Cj4+ICsKPj4gKwkvKiBzZXQgY3B1IERBSSBjb25maWd1cmF0aW9uICovCj4+ICsJcmV0ID0g c25kX3NvY19kYWlfc2V0X2ZtdChjcHVfZGFpLCBkYWlfZm10KTsKPiBTZXQgdGhpcyBpbiB0aGUg ZGFpX2xpbmsgc3RydWN0LgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0 Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxz YS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhengsq@rock-chips.com (Shunqian Zheng) Date: Sat, 24 Oct 2015 11:18:05 +0800 Subject: [PATCH v1 3/4] ASoC: Add codec machine driver for RK3036 In-Reply-To: <20151019191312.GQ32054@sirena.org.uk> References: <1444698070-4191-1-git-send-email-zhengsq@rock-chips.com> <1444698070-4191-4-git-send-email-zhengsq@rock-chips.com> <20151019191312.GQ32054@sirena.org.uk> Message-ID: <562AF86D.8050303@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Mark & Sjoerd, On 2015?10?20? 03:13, Mark Brown wrote: > On Tue, Oct 13, 2015 at 09:01:08AM +0800, Shunqian Zheng wrote: >> From: ZhengShunQian >> >> This patch add the machine driver for rk3036. > Like Sjoerd said this looks like it migh be better just using > simple-card, if not... Yes, simple-card works fine, I think I need to learn more and resend patches. Thank you very much, Shunqian > >> + ret = snd_soc_dai_set_fmt(codec_dai, dai_fmt); >> + if (ret < 0) >> + return ret; >> + >> + /* set cpu DAI configuration */ >> + ret = snd_soc_dai_set_fmt(cpu_dai, dai_fmt); > Set this in the dai_link struct. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbbJXDS3 (ORCPT ); Fri, 23 Oct 2015 23:18:29 -0400 Received: from regular2.263xmail.com ([211.157.152.3]:53602 "EHLO regular2.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbbJXDS2 (ORCPT ); Fri, 23 Oct 2015 23:18:28 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengsq@rock-chips.com X-FST-TO: alsa-devel@alsa-project.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhengsq@rock-chips.com X-UNIQUE-TAG: <25b1d04b26eb6f9845ec9474d24cddf2> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <562AF86D.8050303@rock-chips.com> Date: Sat, 24 Oct 2015 11:18:05 +0800 From: Shunqian Zheng Reply-To: zhengsq@rock-chips.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Mark Brown CC: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, heiko@sntech.de, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, benzh@chromium.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v1 3/4] ASoC: Add codec machine driver for RK3036 References: <1444698070-4191-1-git-send-email-zhengsq@rock-chips.com> <1444698070-4191-4-git-send-email-zhengsq@rock-chips.com> <20151019191312.GQ32054@sirena.org.uk> In-Reply-To: <20151019191312.GQ32054@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark & Sjoerd, On 2015年10月20日 03:13, Mark Brown wrote: > On Tue, Oct 13, 2015 at 09:01:08AM +0800, Shunqian Zheng wrote: >> From: ZhengShunQian >> >> This patch add the machine driver for rk3036. > Like Sjoerd said this looks like it migh be better just using > simple-card, if not... Yes, simple-card works fine, I think I need to learn more and resend patches. Thank you very much, Shunqian > >> + ret = snd_soc_dai_set_fmt(codec_dai, dai_fmt); >> + if (ret < 0) >> + return ret; >> + >> + /* set cpu DAI configuration */ >> + ret = snd_soc_dai_set_fmt(cpu_dai, dai_fmt); > Set this in the dai_link struct.