From: Johannes Sixt <j6t@kdbg.org>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: t3203: --sort=objectsize failure on Windows
Date: Sat, 24 Oct 2015 09:49:27 +0200 [thread overview]
Message-ID: <562B3807.2030203@kdbg.org> (raw)
On Windows, I observe a failure of the test case 'git branch `--sort`
option' introduced by aedcb7dc (branch.c: use 'ref-filter' APIs). The
reason is that the resulting order generated by qsort is unspecified for
entries that compare equal. In fact, the test case sorts 4 entries where
there are only 2 different values.
To achieve a deterministic order, perhaps cmp_ref_sorting() should fall
back to alphabetic comparison if the other criterion (when used)
compares equal?
-- Hannes
next reply other threads:[~2015-10-24 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 7:49 Johannes Sixt [this message]
2015-10-24 14:25 ` t3203: --sort=objectsize failure on Windows Karthik Nayak
2015-10-24 14:42 ` [PATCH] ref-filter: fallback on alphabetical comparison Karthik Nayak
2015-10-25 0:18 ` Eric Sunshine
2015-10-25 7:15 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562B3807.2030203@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.