From: Lars Melin <larsm17@gmail.com>
To: Michele Baldessari <michele@acksyn.org>, Jiri Kosina <jikos@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade
Date: Sun, 25 Oct 2015 16:15:17 +0700 [thread overview]
Message-ID: <562C9DA5.9090800@gmail.com> (raw)
In-Reply-To: <1445701499-13748-1-git-send-email-michele@acksyn.org>
On 2015-10-24 22:44, Michele Baldessari wrote:
> The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order
> to have the two distinct joysticks working.
>
> Before the change:
> $ jstest /dev/input/js0
> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> ...
> $ jstest /dev/input/js1
> jstest: No such file or directory
>
> After the change:
> $ jstest /dev/input/js0
> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> ...
> $ jstest /dev/input/js1
> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> ...
>
> Signed-off-by: Michele Baldessari <michele@acksyn.org>
> ---
> drivers/hid/usbhid/hid-quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 1dff8f0015ba..f69049314a2c 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -150,6 +150,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_MULTIPLE_1781, USB_DEVICE_ID_RAPHNET_4NES4SNES_OLD, HID_QUIRK_MULTI_INPUT },
> { USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_2NES2SNES, HID_QUIRK_MULTI_INPUT },
> { USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_4NES4SNES, HID_QUIRK_MULTI_INPUT },
> + { USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
>
> { 0, 0 }
> };
>
Sorry but I don't believe that XIN_MO is the owner of the 16c0 VID so
should not be given that ownership in linux.
/Lars
next prev parent reply other threads:[~2015-10-25 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 15:44 [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Michele Baldessari
2015-10-24 20:11 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1510242210360.21100-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-10-26 11:00 ` Olivier Scherler
2015-10-26 11:00 ` Olivier Scherler
2015-10-26 12:06 ` Michele Baldessari
2015-10-26 12:06 ` Michele Baldessari
2015-10-25 9:15 ` Lars Melin [this message]
2015-10-25 16:34 ` Michele Baldessari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562C9DA5.9090800@gmail.com \
--to=larsm17@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michele@acksyn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.