From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:58970 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbbJYMQf (ORCPT ); Sun, 25 Oct 2015 08:16:35 -0400 Subject: Re: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN To: Daniel Baluta , Arnd Bergmann References: <22609671.lgCfBiaFIf@wuerfel> Cc: "linux-iio@vger.kernel.org" , Greg Kroah-Hartman , Cristina Opriceana , driverdev , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List From: Jonathan Cameron Message-ID: <562CC820.9060100@kernel.org> Date: Sun, 25 Oct 2015 12:16:32 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 19/10/15 09:16, Daniel Baluta wrote: > On Sat, Oct 17, 2015 at 1:29 AM, Arnd Bergmann wrote: >> The iio dummy code was recently changed to use irq_work_queue, but >> that code is compiled into the kernel only if IRQ_WORK is set, so >> we can get a link error here: >> >> drivers/built-in.o: In function `iio_evgen_poke': >> (.text+0x208a04): undefined reference to `irq_work_queue' >> >> This changes the Kconfig file to match what other drivers do. >> >> Signed-off-by: Arnd Bergmann >> Fixes: fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work") > > Acked-by: Daniel Baluta Applied to the fixes-togreg branch of iio.git. I fear this won't get to Linus until just after the release occurs. Unfortunate timing. Jonathan > >> --- >> Found on ARM randconfig tests >> >> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig >> index 6d5b38d69578..9d7f0004d2d7 100644 >> --- a/drivers/staging/iio/Kconfig >> +++ b/drivers/staging/iio/Kconfig >> @@ -18,7 +18,8 @@ source "drivers/staging/iio/resolver/Kconfig" >> source "drivers/staging/iio/trigger/Kconfig" >> >> config IIO_DUMMY_EVGEN >> - tristate >> + tristate >> + select IRQ_WORK >> >> config IIO_SIMPLE_DUMMY >> tristate "An example driver with no hardware requirements" >> >> -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jic23@kernel.org (Jonathan Cameron) Date: Sun, 25 Oct 2015 12:16:32 +0000 Subject: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN In-Reply-To: References: <22609671.lgCfBiaFIf@wuerfel> Message-ID: <562CC820.9060100@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 19/10/15 09:16, Daniel Baluta wrote: > On Sat, Oct 17, 2015 at 1:29 AM, Arnd Bergmann wrote: >> The iio dummy code was recently changed to use irq_work_queue, but >> that code is compiled into the kernel only if IRQ_WORK is set, so >> we can get a link error here: >> >> drivers/built-in.o: In function `iio_evgen_poke': >> (.text+0x208a04): undefined reference to `irq_work_queue' >> >> This changes the Kconfig file to match what other drivers do. >> >> Signed-off-by: Arnd Bergmann >> Fixes: fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work") > > Acked-by: Daniel Baluta Applied to the fixes-togreg branch of iio.git. I fear this won't get to Linus until just after the release occurs. Unfortunate timing. Jonathan > >> --- >> Found on ARM randconfig tests >> >> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig >> index 6d5b38d69578..9d7f0004d2d7 100644 >> --- a/drivers/staging/iio/Kconfig >> +++ b/drivers/staging/iio/Kconfig >> @@ -18,7 +18,8 @@ source "drivers/staging/iio/resolver/Kconfig" >> source "drivers/staging/iio/trigger/Kconfig" >> >> config IIO_DUMMY_EVGEN >> - tristate >> + tristate >> + select IRQ_WORK >> >> config IIO_SIMPLE_DUMMY >> tristate "An example driver with no hardware requirements" >> >> -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >