From: Jonathan Cameron <jic23@kernel.org>
To: Vladimir Zapolskiy <vz@mleia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: lpc32xx_adc: fix warnings caused by enabling unprepared clock
Date: Sun, 25 Oct 2015 12:22:51 +0000 [thread overview]
Message-ID: <562CC99B.3040105@kernel.org> (raw)
In-Reply-To: <1445107478-2417-1-git-send-email-vz@mleia.com>
On 17/10/15 19:44, Vladimir Zapolskiy wrote:
> If common clock framework is configured, the driver generates a warning,
> which is fixed by this change:
>
> root@devkit3250:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage0_raw
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 724 at drivers/clk/clk.c:727 clk_core_enable+0x2c/0xa4()
> Modules linked in: sc16is7xx snd_soc_uda1380
> CPU: 0 PID: 724 Comm: cat Not tainted 4.3.0-rc2+ #198
> Hardware name: LPC32XX SoC (Flattened Device Tree)
> Backtrace:
> [<>] (dump_backtrace) from [<>] (show_stack+0x18/0x1c)
> [<>] (show_stack) from [<>] (dump_stack+0x20/0x28)
> [<>] (dump_stack) from [<>] (warn_slowpath_common+0x90/0xb8)
> [<>] (warn_slowpath_common) from [<>] (warn_slowpath_null+0x24/0x2c)
> [<>] (warn_slowpath_null) from [<>] (clk_core_enable+0x2c/0xa4)
> [<>] (clk_core_enable) from [<>] (clk_enable+0x24/0x38)
> [<>] (clk_enable) from [<>] (lpc32xx_read_raw+0x38/0x80)
> [<>] (lpc32xx_read_raw) from [<>] (iio_read_channel_info+0x70/0x94)
> [<>] (iio_read_channel_info) from [<>] (dev_attr_show+0x28/0x4c)
> [<>] (dev_attr_show) from [<>] (sysfs_kf_seq_show+0x8c/0xf0)
> [<>] (sysfs_kf_seq_show) from [<>] (kernfs_seq_show+0x2c/0x30)
> [<>] (kernfs_seq_show) from [<>] (seq_read+0x1c8/0x440)
> [<>] (seq_read) from [<>] (kernfs_fop_read+0x38/0x170)
> [<>] (kernfs_fop_read) from [<>] (do_readv_writev+0x16c/0x238)
> [<>] (do_readv_writev) from [<>] (vfs_readv+0x50/0x58)
> [<>] (vfs_readv) from [<>] (default_file_splice_read+0x1a4/0x308)
> [<>] (default_file_splice_read) from [<>] (do_splice_to+0x78/0x84)
> [<>] (do_splice_to) from [<>] (splice_direct_to_actor+0xc8/0x1cc)
> [<>] (splice_direct_to_actor) from [<>] (do_splice_direct+0xa0/0xb8)
> [<>] (do_splice_direct) from [<>] (do_sendfile+0x1a8/0x30c)
> [<>] (do_sendfile) from [<>] (SyS_sendfile64+0x104/0x10c)
> [<>] (SyS_sendfile64) from [<>] (ret_fast_syscall+0x0/0x38)
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Applied to the fixes-togreg branch of iio.git and marked
for stable. Given timing, it will be a couple of weeks before
this hits mainline / stable trees.
Jonathan
> ---
> drivers/staging/iio/adc/lpc32xx_adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/lpc32xx_adc.c b/drivers/staging/iio/adc/lpc32xx_adc.c
> index 5331c44..ef6d0b0 100644
> --- a/drivers/staging/iio/adc/lpc32xx_adc.c
> +++ b/drivers/staging/iio/adc/lpc32xx_adc.c
> @@ -76,7 +76,7 @@ static int lpc32xx_read_raw(struct iio_dev *indio_dev,
>
> if (mask == IIO_CHAN_INFO_RAW) {
> mutex_lock(&indio_dev->mlock);
> - clk_enable(info->clk);
> + clk_prepare_enable(info->clk);
> /* Measurement setup */
> __raw_writel(AD_INTERNAL | (chan->address) | AD_REFp | AD_REFm,
> LPC32XX_ADC_SELECT(info->adc_base));
> @@ -84,7 +84,7 @@ static int lpc32xx_read_raw(struct iio_dev *indio_dev,
> __raw_writel(AD_PDN_CTRL | AD_STROBE,
> LPC32XX_ADC_CTRL(info->adc_base));
> wait_for_completion(&info->completion); /* set by ISR */
> - clk_disable(info->clk);
> + clk_disable_unprepare(info->clk);
> *val = info->value;
> mutex_unlock(&indio_dev->mlock);
>
>
prev parent reply other threads:[~2015-10-25 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 18:44 [PATCH] iio: lpc32xx_adc: fix warnings caused by enabling unprepared clock Vladimir Zapolskiy
2015-10-25 12:22 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562CC99B.3040105@kernel.org \
--to=jic23@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.