All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hauke Mehrtens <hauke@hauke-m.de>
To: Paul Burton <paul.burton@imgtec.com>,
	linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Cc: Matthew Fortune <matthew.fortune@imgtec.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
	Alex Smith <alex@alex-smith.me.uk>,
	linux-kernel@vger.kernel.org,
	Michal Nazarewicz <mina86@mina86.com>,
	Richard Weinberger <richard@nod.at>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Daniel Borkmann <dborkman@redhat.com>,
	Markos Chandras <markos.chandras@imgtec.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	"Maciej W. Rozycki" <macro@codesourcery.com>
Subject: Re: [PATCH 10/16] compile error: MIPS: add definitions for extended context
Date: Sun, 25 Oct 2015 22:10:02 +0100	[thread overview]
Message-ID: <562D452A.5030906@hauke-m.de> (raw)
In-Reply-To: <1436540426-10021-11-git-send-email-paul.burton@imgtec.com>

This patch is causing a build error for me on 4.3-rc7.

  CC      arch/mips/kernel/signal.o
arch/mips/kernel/signal.c: In function 'sc_to_extcontext':
arch/mips/kernel/signal.c:143:12: error: 'struct ucontext' has no member
named 'uc_extcontext'
  return &uc->uc_extcontext;
            ^
In file included from include/linux/poll.h:11:0,
                 from include/linux/ring_buffer.h:7,
                 from include/linux/trace_events.h:5,
                 from include/trace/syscall.h:6,
                 from include/linux/syscalls.h:81,
                 from arch/mips/kernel/signal.c:26:
arch/mips/kernel/signal.c: In function 'save_msa_extcontext':
arch/mips/kernel/signal.c:171:40: error: dereferencing pointer to
incomplete type 'struct msa_extcontext'
   err = __put_user(read_msa_csr(), &msa->csr);
                                        ^
./arch/mips/include/asm/uaccess.h:441:15: note: in definition of macro
'__put_user_nocheck'
  __typeof__(*(ptr)) __pu_val;     \
               ^
arch/mips/kernel/signal.c:171:9: note: in expansion of macro '__put_user'
   err = __put_user(read_msa_csr(), &msa->csr);
         ^
arch/mips/kernel/signal.c:186:20: error: 'MSA_EXTCONTEXT_MAGIC'
undeclared (first use in this function)
  err |= __put_user(MSA_EXTCONTEXT_MAGIC, &msa->ext.magic);
                    ^
./arch/mips/include/asm/uaccess.h:444:14: note: in definition of macro
'__put_user_nocheck'
  __pu_val = (x);       \
              ^
arch/mips/kernel/signal.c:186:9: note: in expansion of macro '__put_user'
  err |= __put_user(MSA_EXTCONTEXT_MAGIC, &msa->ext.magic);
         ^
arch/mips/kernel/signal.c:186:20: note: each undeclared identifier is
reported only once for each function it appears in
  err |= __put_user(MSA_EXTCONTEXT_MAGIC, &msa->ext.magic);
                    ^
./arch/mips/include/asm/uaccess.h:444:14: note: in definition of macro
'__put_user_nocheck'
  __pu_val = (x);       \
              ^
arch/mips/kernel/signal.c:186:9: note: in expansion of macro '__put_user'
  err |= __put_user(MSA_EXTCONTEXT_MAGIC, &msa->ext.magic);
         ^
.......


When I include uapi/asm/ucontext.h instead of asm/ucontext.h in signal.c
it compiles again.

Hauke

  reply	other threads:[~2015-10-25 21:10 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10 15:00 [PATCH 00/16] MSA vector context signal handling & HWCAPs Paul Burton
2015-07-10 15:00 ` Paul Burton
2015-07-10 15:00 ` [PATCH 01/16] MIPS: remove outdated comments in sigcontext.h Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-14 13:56   ` Ralf Baechle
2015-07-10 15:00 ` [PATCH 02/16] MIPS: simplify EVA FP context handling code Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 03/16] MIPS: add offsets to sigcontext FP fields to struct mips_abi Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 04/16] MIPS: use struct mips_abi offsets to save FP context Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-19  0:21   ` Paul Gortmaker
2015-07-19  0:25     ` Ralf Baechle
2015-07-10 15:00 ` [PATCH 05/16] MIPS: move FP usage checks into protected_{save,restore}_fp_context Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 06/16] MIPS: skip odd double FP registers when copying FP32 sigcontext Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 07/16] MIPS: use common FP sigcontext code for O32 compat Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 08/16] MIPS: remove unused {get,put}_sigset functions Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 09/16] MIPS: indicate FP mode in sigcontext sc_used_math Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 10/16] MIPS: add definitions for extended context Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-10-25 21:10   ` Hauke Mehrtens [this message]
2015-10-25 21:47     ` [PATCH 10/16] compile error: " Florian Fainelli
2015-10-25 22:18       ` Hauke Mehrtens
2015-07-10 15:00 ` [PATCH 11/16] MIPS: save MSA extended context around signals Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 12/16] MIPS: AT_HWCAP aux vector infrastructure Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 13/16] MIPS: advertise MIPSr6 via HWCAP when appropriate Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 14/16] MIPS: advertise MSA support via HWCAP when present Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 15/16] MIPS: require O32 FP64 support for MIPS64 with O32 compat Paul Burton
2015-07-10 15:00   ` Paul Burton
2015-07-10 15:00 ` [PATCH 16/16] MIPS: drop EXPERIMENTAL tag from O32+FP64 & MSA Paul Burton
2015-07-10 15:00   ` Paul Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562D452A.5030906@hauke-m.de \
    --to=hauke@hauke-m.de \
    --cc=Zubair.Kakakhel@imgtec.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex@alex-smith.me.uk \
    --cc=dborkman@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=luto@amacapital.net \
    --cc=macro@codesourcery.com \
    --cc=markos.chandras@imgtec.com \
    --cc=matthew.fortune@imgtec.com \
    --cc=mina86@mina86.com \
    --cc=mpe@ellerman.id.au \
    --cc=paul.burton@imgtec.com \
    --cc=peterz@infradead.org \
    --cc=ralf@linux-mips.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.