From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33994)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1ZqWCU-0007cV-VM
	for qemu-devel@nongnu.org; Sun, 25 Oct 2015 21:03:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1ZqWCR-0001s9-Nb
	for qemu-devel@nongnu.org; Sun, 25 Oct 2015 21:03:50 -0400
Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:55600)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1ZqWCR-0001qk-D8
	for qemu-devel@nongnu.org; Sun, 25 Oct 2015 21:03:47 -0400
Received: from localhost
	by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Mon, 26 Oct 2015 01:03:44 -0000
Received: from b06cxnps3075.portsmouth.uk.ibm.com
	(d06relay10.portsmouth.uk.ibm.com [9.149.109.195])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id F3DFB2190056
	for <qemu-devel@nongnu.org>; Mon, 26 Oct 2015 01:03:39 +0000 (GMT)
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com
	[9.149.37.217])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t9Q13gGI66453656
	for <qemu-devel@nongnu.org>; Mon, 26 Oct 2015 01:03:42 GMT
Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t9Q13gIu006953
	for <qemu-devel@nongnu.org>; Sun, 25 Oct 2015 19:03:42 -0600
References: <1445779929-12237-1-git-send-email-pbonzini@redhat.com>
	<1445779929-12237-4-git-send-email-pbonzini@redhat.com>
From: Christian Borntraeger <borntraeger@de.ibm.com>
Message-ID: <562D7BD8.3010106@de.ibm.com>
Date: Mon, 26 Oct 2015 10:03:20 +0900
MIME-Version: 1.0
In-Reply-To: <1445779929-12237-4-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/9] trace: split trace_init_file out of
 trace_init_backends
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: den@openvz.org, armbru@redhat.com, stefanha@redhat.com, peter.maydell@linaro.org

Am 25.10.2015 um 22:32 schrieb Paolo Bonzini:
> diff --git a/trace/control.h b/trace/control.h
> index bfbe560..d2506d4 100644
> --- a/trace/control.h
> +++ b/trace/control.h
> @@ -157,7 +157,7 @@ static void trace_event_set_state_dynamic(TraceEvent *ev, bool state);
>   *
>   * Returns: Whether the backends could be successfully initialized.
>   */
> -bool trace_init_backends(const char *file);
> +bool trace_init_backends(void);
> 
>  /**
>   * trace_init_events:

This (and the patch before) break qemu-io:


/home/cborntra/REPOS/qemu/qemu-io.c: In function 'main':
/home/cborntra/REPOS/qemu/qemu-io.c:443:18: error: too many arguments to function 'trace_init_backends'
             if (!trace_init_backends(optarg, NULL)) {
                  ^
In file included from /home/cborntra/REPOS/qemu/qemu-io.c:26:0:
/home/cborntra/REPOS/qemu/trace/control.h:160:6: note: declared here
 bool trace_init_backends(void);
      ^
/home/cborntra/REPOS/qemu/rules.mak:57: recipe for target 'qemu-io.o' failed


Christian