From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbbJZGG0 (ORCPT ); Mon, 26 Oct 2015 02:06:26 -0400 Received: from lists.s-osg.org ([54.187.51.154]:53184 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753071AbbJZGGY (ORCPT ); Mon, 26 Oct 2015 02:06:24 -0400 Message-ID: <562DC2DA.4070705@osg.samsung.com> Date: Mon, 26 Oct 2015 06:06:18 +0000 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Greg KH CC: linux-kernel@vger.kernel.org, marek.belisko@gmail.com, devel@driverdev.osuosl.org, gulsah.1004@gmail.com, joe@perches.com, daniele.alessandrelli@gmail.com, mahfouz.saif.elyazal@gmail.com, rickard_strandqvist@spectrumdigital.se Subject: Re: [PATCH] staging: ft1000: Remove boolean comparisons References: <1445201895-29443-1-git-send-email-luisbg@osg.samsung.com> <20151025022032.GA28173@kroah.com> In-Reply-To: <20151025022032.GA28173@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/10/15 02:20, Greg KH wrote: > On Sun, Oct 18, 2015 at 09:58:15PM +0100, Luis de Bethencourt wrote: >> Boolean tests do not need explicit comparison to true or false. >> >> Signed-off-by: Luis de Bethencourt >> --- >> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++-- >> drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) > > This driver just got deleted from the tree, sorry :( > Hi Greg, No problem. I see the commit that removed this driver [0] mentions the radio technology service has been discontinued. Great to see drivers removed when they become obsolete instead of zombily maintained. Thanks for the review, Luis [0] https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=6512edec48b2ccfe9bb969ce26ebbbcd49de6c4b