From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqeiy-00057g-Mb for qemu-devel@nongnu.org; Mon, 26 Oct 2015 06:09:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zqeit-0007XM-N4 for qemu-devel@nongnu.org; Mon, 26 Oct 2015 06:09:56 -0400 Received: from s16892447.onlinehome-server.info ([82.165.15.123]:60567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqeit-0007XE-Gx for qemu-devel@nongnu.org; Mon, 26 Oct 2015 06:09:51 -0400 Message-ID: <562DFBD9.4040802@ilande.co.uk> Date: Mon, 26 Oct 2015 10:09:29 +0000 From: Mark Cave-Ayland MIME-Version: 1.0 References: <1432067391-19834-1-git-send-email-rth@twiddle.net> <55964648.8060606@ilande.co.uk> <562DF60F.10509@ilande.co.uk> <20151026100348.GA12077@redhat.com> In-Reply-To: <20151026100348.GA12077@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , QEMU Developers , Richard Henderson On 26/10/15 10:03, Michael S. Tsirkin wrote: > On Mon, Oct 26, 2015 at 09:44:47AM +0000, Mark Cave-Ayland wrote: >> On 27/09/15 15:40, Peter Maydell wrote: >> >>> Ping^2 -- this is still confusing users, cf bug LP:1500175. >>> >>> thanks >>> -- PMM >>> >>> On 6 July 2015 at 11:38, Peter Maydell wrote: >>>> On 3 July 2015 at 09:22, Mark Cave-Ayland wrote: >>>>> On 19/05/15 21:29, Richard Henderson wrote: >>>>> >>>>>> And do not issue an error_report in that case. >>>>>> >>>>>> Signed-off-by: Richard Henderson >>>>>> --- >>>>>> hw/virtio/virtio-pci.c | 15 ++++++++++----- >>>>>> 1 file changed, 10 insertions(+), 5 deletions(-) >>>>>> -- >>>>>> >>>>>> This seems to be about the only sane way to test the value of >>>>>> msi_supported from here. Thoughts? >>>> >>>>> Ping? Any chance of getting this applied for 2.4 since it's something >>>>> that I do get emails about for SPARC64? >>>> >>>> Michael would like a respin with the commit message correction >>>> he suggested. RTH -- could you send out a fixed up version, please? > > I don't think there was a reply to this, and by now the patch doesn't apply. Hmmm that's a shame. I'm not overly familiar with the PCI parts of QEMU, so is it much work to rebase? >>>> >>>> thanks >>>> -- PMM >> >> Another ping on this patch - please can we have it for 2.5? It has been >> around since before 2.4 and I'd hate for it to miss another release :( >> >> >> ATB, >> >> Mark. > > Pls address the issues if you want this applied. The patch came from Richard rather than myself - my only involvement has been to champion the patch since both myself and Peter have had reports of this message confusing users. ATB, Mark.