From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Auger Subject: Re: [PATCH v3] VFIO: platform: reset: AMD xgbe reset module Date: Mon, 26 Oct 2015 11:22:48 +0100 Message-ID: <562DFEF8.5090904@linaro.org> References: <201510241614.F4vZ38k0%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5721641172 for ; Mon, 26 Oct 2015 06:20:06 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EGk8RXLjJfkf for ; Mon, 26 Oct 2015 06:20:05 -0400 (EDT) Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id CC95340FA7 for ; Mon, 26 Oct 2015 06:20:04 -0400 (EDT) Received: by wicll6 with SMTP id ll6so106984414wic.1 for ; Mon, 26 Oct 2015 03:22:52 -0700 (PDT) In-Reply-To: <201510241614.F4vZ38k0%fengguang.wu@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: kbuild test robot Cc: thomas.lendacky@amd.com, kvm@vger.kernel.org, arnd@arndb.de, patches@linaro.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, kbuild-all@01.org, eric.auger@st.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: kvmarm@lists.cs.columbia.edu Dear all, I think the problem comes from the fact this patch applies on top of "VFIO platform reset module rework", https://lkml.org/lkml/2015/10/23/385. This is where module_vfio_reset_handler macro is introduced. Maybe I should have reverted the patch into RFC after decision to rework the framework. Best Regards Eric On 10/24/2015 10:41 AM, kbuild test robot wrote: > Hi Eric, > > [auto build test ERROR on asm-generic/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] > > url: https://github.com/0day-ci/linux/commits/Eric-Auger/VFIO-platform-reset-AMD-xgbe-reset-module/20151024-000245 > config: arm-allyesconfig (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > >>> drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:27: error: expected declaration specifiers or '...' before string constant > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ >>> drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:51: error: expected declaration specifiers or '...' before 'vfio_platform_amdxgbe_reset' > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ > -- >>> /kbuild/src/defs/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:27: error: expected declaration specifiers or '...' before string constant > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ >>> /kbuild/src/defs/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:51: error: expected declaration specifiers or '...' before 'vfio_platform_amdxgbe_reset' > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ > > vim +122 drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > > 116 if (!count) > 117 pr_warn("%s MAC SW reset failed\n", __func__); > 118 > 119 return 0; > 120 } > 121 > > 122 module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > 123 > 124 MODULE_VERSION("0.1"); > 125 MODULE_LICENSE("GPL v2"); > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric.auger@linaro.org (Eric Auger) Date: Mon, 26 Oct 2015 11:22:48 +0100 Subject: [PATCH v3] VFIO: platform: reset: AMD xgbe reset module In-Reply-To: <201510241614.F4vZ38k0%fengguang.wu@intel.com> References: <201510241614.F4vZ38k0%fengguang.wu@intel.com> Message-ID: <562DFEF8.5090904@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear all, I think the problem comes from the fact this patch applies on top of "VFIO platform reset module rework", https://lkml.org/lkml/2015/10/23/385. This is where module_vfio_reset_handler macro is introduced. Maybe I should have reverted the patch into RFC after decision to rework the framework. Best Regards Eric On 10/24/2015 10:41 AM, kbuild test robot wrote: > Hi Eric, > > [auto build test ERROR on asm-generic/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] > > url: https://github.com/0day-ci/linux/commits/Eric-Auger/VFIO-platform-reset-AMD-xgbe-reset-module/20151024-000245 > config: arm-allyesconfig (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > >>> drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:27: error: expected declaration specifiers or '...' before string constant > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ >>> drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:51: error: expected declaration specifiers or '...' before 'vfio_platform_amdxgbe_reset' > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ > -- >>> /kbuild/src/defs/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:27: error: expected declaration specifiers or '...' before string constant > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ >>> /kbuild/src/defs/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:51: error: expected declaration specifiers or '...' before 'vfio_platform_amdxgbe_reset' > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ > > vim +122 drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > > 116 if (!count) > 117 pr_warn("%s MAC SW reset failed\n", __func__); > 118 > 119 return 0; > 120 } > 121 > > 122 module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > 123 > 124 MODULE_VERSION("0.1"); > 125 MODULE_LICENSE("GPL v2"); > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753745AbbJZKWz (ORCPT ); Mon, 26 Oct 2015 06:22:55 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:34554 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753589AbbJZKWx (ORCPT ); Mon, 26 Oct 2015 06:22:53 -0400 Subject: Re: [PATCH v3] VFIO: platform: reset: AMD xgbe reset module To: kbuild test robot References: <201510241614.F4vZ38k0%fengguang.wu@intel.com> Cc: kbuild-all@01.org, eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, arnd@arndb.de, thomas.lendacky@amd.com, Suravee.Suthikulpanit@amd.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org, linux-kernel@vger.kernel.org, patches@linaro.org From: Eric Auger Message-ID: <562DFEF8.5090904@linaro.org> Date: Mon, 26 Oct 2015 11:22:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <201510241614.F4vZ38k0%fengguang.wu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear all, I think the problem comes from the fact this patch applies on top of "VFIO platform reset module rework", https://lkml.org/lkml/2015/10/23/385. This is where module_vfio_reset_handler macro is introduced. Maybe I should have reverted the patch into RFC after decision to rework the framework. Best Regards Eric On 10/24/2015 10:41 AM, kbuild test robot wrote: > Hi Eric, > > [auto build test ERROR on asm-generic/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] > > url: https://github.com/0day-ci/linux/commits/Eric-Auger/VFIO-platform-reset-AMD-xgbe-reset-module/20151024-000245 > config: arm-allyesconfig (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > >>> drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:27: error: expected declaration specifiers or '...' before string constant > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ >>> drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:51: error: expected declaration specifiers or '...' before 'vfio_platform_amdxgbe_reset' > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ > -- >>> /kbuild/src/defs/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:27: error: expected declaration specifiers or '...' before string constant > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ >>> /kbuild/src/defs/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:122:51: error: expected declaration specifiers or '...' before 'vfio_platform_amdxgbe_reset' > module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > ^ > > vim +122 drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > > 116 if (!count) > 117 pr_warn("%s MAC SW reset failed\n", __func__); > 118 > 119 return 0; > 120 } > 121 > > 122 module_vfio_reset_handler("amd,xgbe-seattle-v1a", vfio_platform_amdxgbe_reset); > 123 > 124 MODULE_VERSION("0.1"); > 125 MODULE_LICENSE("GPL v2"); > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation >