From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s} Date: Mon, 26 Oct 2015 10:53:38 +0000 Message-ID: <562E0632.3060102@citrix.com> References: <1445596390-31298-1-git-send-email-julien.grall@citrix.com> <562E007F.9010607@citrix.com> <562E111E02000078000AE749@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqfPM-00080h-Br for xen-devel@lists.xenproject.org; Mon, 26 Oct 2015 10:53:44 +0000 In-Reply-To: <562E111E02000078000AE749@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , George Dunlap , Andrew Cooper , Dario Faggioli , Julien Grall , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 26/10/15 10:40, Jan Beulich wrote: >>>> On 26.10.15 at 11:29, wrote: >> On 23/10/15 11:33, Julien Grall wrote: >>> Note that the patch has only been build tested. >> >> It would be nice if we could properly test the codepath in question >> before checking it in, but we have lots of time before the release for >> people to find this sort of thing. > > To be honest, I'd rather put it in right away. There's no strict need > to backport it, and in case there is a problem we can always fix/revert > in -unstable. Most of the changes to memory hot (un)plug paths go > in that way, due to the rareness of systems to test such on. Indeed, that's what I meant -- we should check it in right away, to maximize the possibility that if there is a bug, it will be caught in all the testing (both ad-hoc and explicit) that will happen between now and the next release. -George