From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753671AbbJZLt3 (ORCPT ); Mon, 26 Oct 2015 07:49:29 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:14353 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753406AbbJZLt2 (ORCPT ); Mon, 26 Oct 2015 07:49:28 -0400 Message-ID: <562E132B.7080407@huawei.com> Date: Mon, 26 Oct 2015 19:48:59 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Adrian Hunter , Arnaldo Carvalho de Melo , pi3orama CC: , Alexei Starovoitov , Peter Zijlstra , Li Zefan Subject: Re: [RFC PATCH] perf tools: Don't set inherit bit for system wide evsel References: <1445597029-133332-1-git-send-email-wangnan0@huawei.com> <20151023135141.GD27006@kernel.org> <3E5B2C7C-BD19-4B61-AEDC-D1E2CFE0D7D2@163.com> <20151023161749.GF27006@kernel.org> <562DED7D.2080306@huawei.com> <562DF19B.2080608@intel.com> In-Reply-To: <562DF19B.2080608@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.562E1338.002D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: aa9a030c07f0bfb14d5fd5db7acf3487 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/10/26 17:25, Adrian Hunter wrote: > On 26/10/15 11:08, Wangnan (F) wrote: >> >> evsel->system_wide is introduced by commit >> bf8e8f4b832972c76d64ab2e2837a48397144887 >> (perf evlist: Add 'system_wide' option), but Adrian only introduced a new field >> into perf, doesn't really make it active. Until now the only user of it is >> arch/x86/util/intel-pt.c, but I'm not very sure the reason for IPT to use that >> field. >> >> If I understand correctly, it should be okay for a normal system wide evsel >> to have >> this var set. I'll try another RFC for it. > evsel->system_wide is for mixing evsels that aren't system-wide with ones > that are. > > It might work to set it for all system-wide evsels but you will have to > check the code and test it, because that would be using it in a new way > that has never been tested. I have check all occurance of system_wide I can found and found only one behavior change which I believe should be okay. Please have a look at [1]. Thank you. [1] http://lkml.kernel.org/g/1445859720-146146-1-git-send-email-wangnan0@huawei.com