From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: <qemu-devel@nongnu.org>
Cc: qemu-trivial@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] fix bad indentation in pcie_cap_slot_write_config()
Date: Mon, 26 Oct 2015 20:07:34 +0800 [thread overview]
Message-ID: <562E1786.9040202@cn.fujitsu.com> (raw)
In-Reply-To: <1445761408-10308-1-git-send-email-caoj.fnst@cn.fujitsu.com>
Sorry, I just find that maybe I should cc this patch to
qemu-trivial@nongnu.org
On 10/25/2015 04:23 PM, Cao jin wrote:
> bad indentation conflicts with CODING_STYLE doc
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/pci/pcie.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 6e28985..e4bfe91 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -413,13 +413,13 @@ void pcie_cap_slot_write_config(PCIDevice *dev,
> */
> if ((sltsta & PCI_EXP_SLTSTA_PDS) && (val & PCI_EXP_SLTCTL_PCC) &&
> ((val & PCI_EXP_SLTCTL_PIC_OFF) == PCI_EXP_SLTCTL_PIC_OFF)) {
> - PCIBus *sec_bus = pci_bridge_get_sec_bus(PCI_BRIDGE(dev));
> - pci_for_each_device(sec_bus, pci_bus_num(sec_bus),
> - pcie_unplug_device, NULL);
> + PCIBus *sec_bus = pci_bridge_get_sec_bus(PCI_BRIDGE(dev));
> + pci_for_each_device(sec_bus, pci_bus_num(sec_bus),
> + pcie_unplug_device, NULL);
>
> - pci_word_test_and_clear_mask(exp_cap + PCI_EXP_SLTSTA,
> - PCI_EXP_SLTSTA_PDS);
> - pci_word_test_and_set_mask(exp_cap + PCI_EXP_SLTSTA,
> + pci_word_test_and_clear_mask(exp_cap + PCI_EXP_SLTSTA,
> + PCI_EXP_SLTSTA_PDS);
> + pci_word_test_and_set_mask(exp_cap + PCI_EXP_SLTSTA,
> PCI_EXP_SLTSTA_PDC);
> }
>
>
--
Yours Sincerely,
Cao Jin
WARNING: multiple messages have this Message-ID (diff)
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] fix bad indentation in pcie_cap_slot_write_config()
Date: Mon, 26 Oct 2015 20:07:34 +0800 [thread overview]
Message-ID: <562E1786.9040202@cn.fujitsu.com> (raw)
In-Reply-To: <1445761408-10308-1-git-send-email-caoj.fnst@cn.fujitsu.com>
Sorry, I just find that maybe I should cc this patch to
qemu-trivial@nongnu.org
On 10/25/2015 04:23 PM, Cao jin wrote:
> bad indentation conflicts with CODING_STYLE doc
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/pci/pcie.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 6e28985..e4bfe91 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -413,13 +413,13 @@ void pcie_cap_slot_write_config(PCIDevice *dev,
> */
> if ((sltsta & PCI_EXP_SLTSTA_PDS) && (val & PCI_EXP_SLTCTL_PCC) &&
> ((val & PCI_EXP_SLTCTL_PIC_OFF) == PCI_EXP_SLTCTL_PIC_OFF)) {
> - PCIBus *sec_bus = pci_bridge_get_sec_bus(PCI_BRIDGE(dev));
> - pci_for_each_device(sec_bus, pci_bus_num(sec_bus),
> - pcie_unplug_device, NULL);
> + PCIBus *sec_bus = pci_bridge_get_sec_bus(PCI_BRIDGE(dev));
> + pci_for_each_device(sec_bus, pci_bus_num(sec_bus),
> + pcie_unplug_device, NULL);
>
> - pci_word_test_and_clear_mask(exp_cap + PCI_EXP_SLTSTA,
> - PCI_EXP_SLTSTA_PDS);
> - pci_word_test_and_set_mask(exp_cap + PCI_EXP_SLTSTA,
> + pci_word_test_and_clear_mask(exp_cap + PCI_EXP_SLTSTA,
> + PCI_EXP_SLTSTA_PDS);
> + pci_word_test_and_set_mask(exp_cap + PCI_EXP_SLTSTA,
> PCI_EXP_SLTSTA_PDC);
> }
>
>
--
Yours Sincerely,
Cao Jin
next prev parent reply other threads:[~2015-10-26 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 8:23 [Qemu-devel] [PATCH] fix bad indentation in pcie_cap_slot_write_config() Cao jin
2015-10-26 12:07 ` Cao jin [this message]
2015-10-26 12:07 ` Cao jin
2015-10-26 12:16 ` [Qemu-trivial] " Michael S. Tsirkin
2015-10-26 12:16 ` Michael S. Tsirkin
2015-10-29 7:45 ` [Qemu-trivial] " Michael Tokarev
2015-10-29 7:45 ` [Qemu-devel] " Michael Tokarev
2015-10-29 7:57 ` [Qemu-trivial] " Cao jin
2015-10-29 7:57 ` [Qemu-devel] " Cao jin
2015-10-29 8:07 ` [Qemu-trivial] " Michael Tokarev
2015-10-29 8:07 ` [Qemu-devel] " Michael Tokarev
2015-10-29 8:28 ` [Qemu-trivial] " Cao jin
2015-10-29 8:28 ` [Qemu-devel] " Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E1786.9040202@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.