From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753776AbbJZM1S (ORCPT ); Mon, 26 Oct 2015 08:27:18 -0400 Received: from mga09.intel.com ([134.134.136.24]:27899 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbbJZM1R (ORCPT ); Mon, 26 Oct 2015 08:27:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,201,1444719600"; d="scan'208";a="588146291" Subject: Re: [RFC PATCH v2 1/2] perf tools: Set evsel->system_wide field for global system wide recording To: Wang Nan , acme@kernel.org, ast@plumgrid.com References: <1445859720-146146-1-git-send-email-wangnan0@huawei.com> <1445859720-146146-2-git-send-email-wangnan0@huawei.com> Cc: linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com, Arnaldo Carvalho de Melo , Peter Zijlstra From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <562E1B6F.2020202@intel.com> Date: Mon, 26 Oct 2015 14:24:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445859720-146146-2-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/10/15 13:41, Wang Nan wrote: > evsel->system_wide is introduced by commit bf8e8f4b832972c76d64ab2e2837 > (perf evlist: Add 'system_wide' option), which is used for mixing evsels > that aren't system-wide with ones that are [1]. However, for global > system wide recording (perf record -a ...), evsel->system_wide is set > to false, which is confusion. > > This patch set evsel->system_wide to true if the target.system_wide is > set, which makes evsel->system_wide a reliable way to describe whether > itself is system_wide or not. > > [1] http://lkml.kernel.org/r/562DF19B.2080608@intel.com > > Signed-off-by: Wang Nan > Cc: Adrian Hunter > Cc: Arnaldo Carvalho de Melo > Cc: Alexei Starovoitov > Cc: Peter Zijlstra > Cc: Li Zefan > Cc: pi3orama@163.com > Link: http://lkml.kernel.org/n/ebpf-qm3gtwidc1o5ktjd9tgjex25@git.kernel.org > --- > tools/perf/util/evsel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 3ac4ee9c..36ecf0e 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -734,6 +734,7 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts) > int track = evsel->tracking; > bool per_cpu = opts->target.default_per_cpu && !opts->target.per_thread; > > + evsel->system_wide = opts->target.system_wide; Well that breaks the way evsel->system_wide is used i.e. it is a parameter to the evsel and here you just overwrote it. > attr->sample_id_all = perf_missing_features.sample_id_all ? 0 : 1; > attr->inherit = !opts->no_inherit; > >