Re: [PATCH 1/2] xen/x86: Helpers for cpu feature manipuation

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 26/10/15 12:06, Jan Beulich wrote:
>>>> On 26.10.15 at 12:17, <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/arch/x86/cpu/common.c
>> +++ b/xen/arch/x86/cpu/common.c
>> @@ -202,7 +202,7 @@ static void __init early_cpu_detect(void)
>>  	c->x86_mask = tfms & 15;
>>  	cap0 &= ~cleared_caps[0];
>>  	cap4 &= ~cleared_caps[4];
>> -	if (cap0 & (1<<19))
>> +	if (cap0 & cpufeat_mask(X86_FEATURE_CLFLSH))
> This one's particularly well spotted! Thanks!

I doubt I have found all instances like this.  I only found this one
because of the associated changes in the subsequent patch.

I will be fixing them as I find them.

~Andrew