From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757AbbJZQ4P (ORCPT ); Mon, 26 Oct 2015 12:56:15 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:39327 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbbJZQ4M (ORCPT ); Mon, 26 Oct 2015 12:56:12 -0400 Subject: Re: [PATCH net] RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv To: Sowmini Varadhan , rds-devel@oss.oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20151026164637.GK10039@oracle.com> Cc: davem@davemloft.net From: santosh shilimkar Organization: Oracle Corporation Message-ID: <562E5B21.2070509@oracle.com> Date: Mon, 26 Oct 2015 09:56:01 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151026164637.GK10039@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2015 9:46 AM, Sowmini Varadhan wrote: > > Either of pskb_pull() or pskb_trim() may fail under low memory conditions. > If rds_tcp_data_recv() ignores such failures, the application will > receive corrupted data because the skb has not been correctly > carved to the RDS datagram size. > > Avoid this by handling pskb_pull/pskb_trim failure in the same > manner as the skb_clone failure: bail out of rds_tcp_data_recv(), and > retry via the deferred call to rds_send_worker() that gets set up on > ENOMEM from rds_tcp_read_sock() > > Signed-off-by: Sowmini Varadhan > --- Good one. Probably we should get this fix in stable versions as well. It seems to be applicable for all v2.6.32+ stable versions. FWIW, Acked-by: Santosh Shilimkar Regards, Santosh