From: Carol Soto <clsoto@linux.vnet.ibm.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>,
brking@linux.vnet.ibm.com,
Jack Morgenstein <jackm@dev.mellanox.co.il>
Subject: Re: [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe
Date: Mon, 26 Oct 2015 13:27:18 -0500 [thread overview]
Message-ID: <562E7086.9000204@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJ3xEMgFjen8EY6WX3Zpk1k4pAou=HF8ZZHVVnaUtwePAZrcUg@mail.gmail.com>
On 10/26/2015 12:02 PM, Or Gerlitz wrote:
> On Mon, Oct 26, 2015 at 5:15 PM, <clsoto@linux.vnet.ibm.com> wrote:
>> From: Carol L Soto <clsoto@linux.vnet.ibm.com>
>>
>> If the caps.eqe_size is bigger than the struct mlx4_eqe then there
>> is a potential for corrupting data at the master context. We can see
>> the message "Master failed to generate an EQE for slave: X" when the
>> event_eqe array wraps and we can see potential oops at the function
>> mlx4_GEN_EQE. Also correct a memset of cmd_eqe to use the sizeof
>> mlx4_eqe instead of eqe_size.
>>
>> Fixes: 08ff32352d6f ('mlx4: 64-byte CQE/EQE support')
>> Signed-off-by: Carol L Soto <clsoto@linux.vnet.ibm.com>
> Thanks Carol, I'd like to review this a bit more tomorrow and will
> send it with another fix/es to net
Sure thanks.
prev parent reply other threads:[~2015-10-26 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 15:15 [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe clsoto
2015-10-26 17:02 ` Or Gerlitz
2015-10-26 18:27 ` Carol Soto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E7086.9000204@linux.vnet.ibm.com \
--to=clsoto@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=jackm@dev.mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.