From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: allow best-effort query
Date: Mon, 26 Oct 2015 12:56:32 -0600 [thread overview]
Message-ID: <562E7760.1080503@redhat.com> (raw)
In-Reply-To: <1445883177-11795-1-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On 10/26/2015 12:12 PM, John Snow wrote:
> For more complex BDS trees that can be created under normal circumstances,
> we lose the ability to issue query commands because of our inability to
> re-construct the absolute filename.
>
> Instead, omit this field when it is a problem and present as much information
> as we can.
>
> This will change the expected output in iotest 110, where we will now see a
> json filename and the lack of an absolute filename instead of an error.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> block/qapi.c | 10 ++++++----
> tests/qemu-iotests/110.out | 5 ++++-
> 2 files changed, 10 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
Partial is indeed better than nothing :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-26 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 18:12 [Qemu-devel] [PATCH] block: allow best-effort query John Snow
2015-10-26 18:56 ` Eric Blake [this message]
2015-10-26 21:18 ` Max Reitz
2015-10-26 21:34 ` John Snow
2015-10-26 22:22 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E7760.1080503@redhat.com \
--to=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.